Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKI Certificate Details #18737

Merged
merged 5 commits into from
Jan 18, 2023
Merged

PKI Certificate Details #18737

merged 5 commits into from
Jan 18, 2023

Conversation

zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Jan 17, 2023 •
edited
Loading

  • Added component for certificate details
  • Dropped in details component in PkiRoleGenerate
  • Added base certificate serializer
  • Expanded base certificate adapter
  • Removed old certificate adapter

pki/certificates/:id
image
pki/roles/:id/generate
image

@zofskeez zofskeez added this to the 1.13.0-rc1 milestone Jan 17, 2023
hellobontempo
hellobontempo approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments - nothing blocking. Thanks for the cleanup work! ✨

@zofskeez zofskeez enabled auto-merge (squash) January 18, 2023 00:24
@zofskeez zofskeez merged commit 9d46671 into main Jan 18, 2023
@zofskeez zofskeez deleted the ui/VAULT-9265/pki-cert-read branch January 18, 2023 01:54
@hashishaw hashishaw mentioned this pull request Jan 27, 2023
Merged
This was referenced Feb 21, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellobontempo hellobontempo hellobontempo approved these changes

Assignees
No one assigned
Labels
pr/no-changelog ui
Projects
None yet
Milestone
1.13.0-rc1
Development

Successfully merging this pull request may close these issues.
2 participants
@zofskeez @hellobontempo