Normalize error response to stop information leakage #23072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hghaf099
reviewed
Sep 18, 2023
| @@ -0,0 +1,3 @@ | |||
| ```release-note:security | |||
There was a problem hiding this comment.
Similar to another issue, please call this out as a change!
There was a problem hiding this comment.
And the message is unnecessarily too long. Would you please make it consistent with the other change:
auth/approle: Normalize error response messages when invalid credentials are provided
| @@ -99,7 +99,7 @@ func (b *backend) pathLoginResolveRole(ctx context.Context, req *logical.Request | |||
| return nil, err | |||
| } | |||
| if roleIDIndex == nil { | |||
| return logical.ErrorResponse("invalid role ID"), nil | |||
| return logical.ErrorResponse("invalid role or secret ID"), nil | |||
There was a problem hiding this comment.
It seems that the error response could also be changed to logical.ErrInvalidCredentials for here and the rest of the changes.
|
@jamiewri we are looking forward to getting this PR merged. Are you still interested in working on the required fixes in the feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to the work done in this PR to stop information leakage via HTTP error codes with partially correct log ins. This PR normalizes the returned error message for the same reasons.