Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add version 1 if KV engine has no version data #23585

Merged
merged 10 commits into from
Oct 11, 2023
Merged

UI: Add version 1 if KV engine has no version data #23585

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4c639f3
add logic to add version 1
hellobontempo Oct 10, 2023
3135013
add comments
hellobontempo Oct 10, 2023
565f5eb
add changelog
hellobontempo Oct 10, 2023
47432da
add test
hellobontempo Oct 10, 2023
8483a3a
remove redundant backend check
hellobontempo Oct 10, 2023
e06a7ac
add v2 test
hellobontempo Oct 10, 2023
742269a
Merge branch 'main' into ui/VAULT-20811/assume-kv-v1-if-no-version-data
hellobontempo Oct 10, 2023
a77fcc5
use optional chaining in conditional because this serializer is used …
hellobontempo Oct 10, 2023
2a26909
Merge branch 'main' into ui/VAULT-20811/assume-kv-v1-if-no-version-data
hellobontempo Oct 10, 2023
98ac679
Merge branch 'main' into ui/VAULT-20811/assume-kv-v1-if-no-version-data
hellobontempo Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ui/app/serializers/secret-engine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ export default ApplicationSerializer.extend(EmbeddedRecordsMixin, {
// strip the trailing slash off of the path so we
// can navigate to it without getting `//` in the url
struct.id = struct.path.slice(0, -1);

// enabling kv in the CLI without a version flag mounts a v1 engine
// however, the options object is null so setting version number manually
if (backend.type === 'kv' && !backend.options) {
backend.options = { version: 1 };
}
return struct;
},

Expand Down