enterprise: Default Lease Count Quota #24382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
mpalmi
force-pushed
the
default-lcq
branch
2 times, most recently
from
1e73abc to
592b9e1
Compare
This commit introduces the plumbing for Default Lease Count Quotas on new installs of Vault Enterprise.
|
Build Results: |
mpalmi
changed the title
raskchanky
approved these changes
Dec 8, 2023
| ```release-note:feature | ||
| **Default Lease Count Quota**: Apply a new global default lease count quota of 300k leases for all | ||
| new installs of Vault. | ||
| ``` |
There was a problem hiding this comment.
Nit: given that lease count quotas are an enterprise only feature, does it make more sense to have the changelog be on the enterprise PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the CE portion of Default Lease Count Quotas, as defined in the RFC.
This PR resolves VAULT-20142.
Implementation
One note-worthy implementation requirement is the need for an automatic default quota that can be modified or deleted. To support this requirement, we check the version store during early unseal for empty version history. N.B. version history is populated at the end of early unseal, and until then it will be empty IF AND ONLY IF this is a new install of Vault.
Using this check, we can persist a quota during early unseal. This workflow allows us to support deleting or modifying the Default global quota after first unseal without it being overwritten on restart.
We don't need to worry about populating the new quota in memory, since it will happen later during the unseal process (along with the rest of the quotas).
Testing
This PR contains unit testing for the IsNewInstall logic.
All further testing of the new functionality will take place on a separate PR in the Enterprise repo.
Documentation
There are some minor documentation updates to clarify quota precedence and to introduce the concept of a Default quota.
A separate PR will be submitted to provide more context around Good Quota Creation ™️ and other helpful customer-facing context.