Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache trusted cert values, invalidating when anything changes (#25421) #25464

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

sgmiller
Copy link
Collaborator

Backport from main to 1.14.x

* Cache trusted cert values, invalidating when anything changes

* rename to something more indicative

* defer

* changelog

* Use an LRU cache rather than a static map so we can't use too much memory.  Add docs, unit tests

* Don't add to cache if disabled.  But this races if just a bool, so make the disabled an atomic
@sgmiller sgmiller requested a review from a team as a code owner February 15, 2024 21:56
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 15, 2024
@sgmiller sgmiller added this to the 1.14.10 milestone Feb 15, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All required Go tests succeeded but failures were detected ⚠️
Failures:

Test Type Package Test Logs
race vault TestOIDC_PeriodicFunc view test results
race vault TestOIDC_PeriodicFunc/test-key-nil-next-signing-key view test results

@sgmiller sgmiller merged commit 35bb12a into release/1.14.x Feb 20, 2024
73 of 76 checks passed
@sgmiller sgmiller deleted the sgm/backport-cert-trust-cache/1.14.x branch February 20, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants