Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: Now enterprise-only #25640

Merged
merged 3 commits into from
Feb 26, 2024
Merged

events: Now enterprise-only #25640

merged 3 commits into from
Feb 26, 2024

Conversation

swenson
Copy link
Contributor

@swenson swenson commented Feb 26, 2024

This removes the WebSockets endpoint for events
(which will be moved to the Enterprise repo) and
disables tests that rely on it unless they are
running in Enterprise.

It also updates documentation to document that
events are only available in Vault Enterprise.

@swenson swenson added this to the 1.16.0 milestone Feb 26, 2024
@swenson swenson requested review from VioletHynes and a team February 26, 2024 19:19
@swenson swenson requested a review from a team as a code owner February 26, 2024 19:19
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 26, 2024
Copy link

github-actions bot commented Feb 26, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Feb 26, 2024

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! I'll be handling the proxy tests here: #25641

Christopher Swenson added 3 commits February 26, 2024 11:43
This removes the WebSockets endpoint for events
(which will be moved to the Enterprise repo) and
disables tests that rely on it unless they are
running in Enterprise.

It also updates documentation to document that
events are only available in Vault Enterprise.
@swenson swenson force-pushed the disable-event-websocket branch from fc1e2ba to 96decbf Compare February 26, 2024 19:45
@swenson
Copy link
Contributor Author

swenson commented Feb 26, 2024

Thanks!

@swenson swenson enabled auto-merge (squash) February 26, 2024 19:46
@swenson swenson merged commit ae9ec39 into main Feb 26, 2024
86 checks passed
@swenson swenson deleted the disable-event-websocket branch February 26, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants