VAULT-23553: Revert "Don't panic on unknown raft ops" #25991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
raskchanky
reviewed
Mar 18, 2024
physical/raft/fsm.go
Outdated
| @@ -678,24 +677,24 @@ func (f *FSM) ApplyBatch(logs []*raft.Log) []interface{} { | |||
| // Do the unmarshalling first so we don't hold locks | |||
| var latestConfiguration *ConfigurationValue | |||
| commands := make([]interface{}, 0, numLogs) | |||
| for _, l := range logs { | |||
There was a problem hiding this comment.
Nit: I have a very mild preference that variable names not shadow package names, just for the sake of readability, which is why I changed all these log references in the original PR. Not a big deal by any means.
raskchanky
reviewed
Mar 18, 2024
|
Build Results: |
Co-authored-by: Josh Black <[email protected]>
raskchanky
reviewed
Mar 19, 2024
| r := recover() | ||
| require.NotNil(t, r) | ||
| require.Contains(t, r, "failed to store data") | ||
| }() |
There was a problem hiding this comment.
This is a very cool trick! I didn't know you could do that.
raskchanky
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the change as part of undo logs, and adds a test to verify that an unknown operation will panic.