-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usePrivateIP for cloudsql postgresql instances #26828
Conversation
Signed-off-by: aviv guiser <[email protected]>
Signed-off-by: aviv guiser <[email protected]>
Hello @hsimon-hashicorp! |
Hi there! Thank you for the ping (genuinely, I appreciate it!) as well as your enthusiasm for this PR. I will check with our engineering and product management teams to see if we can get some eyes on this. I can't make any guarantees about timelines, but this does give me more data about community sentiment which is very valuable to me. Thanks again! ^_^ |
Hey @hsimon-hashicorp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KyriosGN0
Thanks for the contribution!
In addition to the nit I left in the code, two additions are needed.
- A changelog file needs to be added.
A new file named26828.txt
should be placed in thechangelog
directory with the following contents:
```release-note:improvement
secrets/database: Add support for GCP CloudSQL private IP's.
```
- Documentation updates are needed.
The "Configure connection" section of the API docs located here will need to be updated to include this new configuration field. That file is located atwebsite/content/api-docs/secret/databases/postgresql.mdx
The Setup portion of the "Authenticating to Cloud DBs via IAM" section of the feature documentation located here will need to be updated to include its use. This can be as simple as adding a new line to both CLI command examples to sayuse_private_ip="false"
. That file is located atwebsite/content/docs/secrets/databases/postgresql.mdx
.
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
hey @robmonte, Thanks you for the review, i addressed the nit in the code and added the required docs changes |
Co-authored-by: Robert <[email protected]>
@robmonte could you trigger the tests again ? |
🛠️ Description
add the ability to speificy if the cloudsql postgresql instance has private ip we should use
right now we fail if the instance has only public ip
Closes #26827