Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usePrivateIP for cloudsql postgresql instances #26828

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Add usePrivateIP for cloudsql postgresql instances #26828

merged 5 commits into from
Jun 25, 2024

Conversation

KyriosGN0
Copy link
Contributor

@KyriosGN0 KyriosGN0 commented May 4, 2024

🛠️ Description

add the ability to speificy if the cloudsql postgresql instance has private ip we should use
right now we fail if the instance has only public ip

Closes #26827

@KyriosGN0 KyriosGN0 requested a review from a team as a code owner May 4, 2024 18:22
@heatherezell heatherezell added ecosystem database/gcp/cloudsql bug Used to indicate a potential bug labels May 7, 2024
@sviatlo
Copy link

sviatlo commented May 11, 2024

Hello @hsimon-hashicorp!
We've been dreaming of using Vault to authenticate with gcp sql. Is there any chance you can help to facilitate/expedite the review of this PR?
Thank you in advance!

@heatherezell
Copy link
Contributor

Hello @hsimon-hashicorp! We've been dreaming of using Vault to authenticate with gcp sql. Is there any chance you can help to facilitate/expedite the review of this PR? Thank you in advance!

Hi there! Thank you for the ping (genuinely, I appreciate it!) as well as your enthusiasm for this PR. I will check with our engineering and product management teams to see if we can get some eyes on this. I can't make any guarantees about timelines, but this does give me more data about community sentiment which is very valuable to me. Thanks again! ^_^

@KyriosGN0
Copy link
Contributor Author

Hey @hsimon-hashicorp
Is there possibly some update about my PR?

Copy link
Member

@robmonte robmonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KyriosGN0
Thanks for the contribution!

In addition to the nit I left in the code, two additions are needed.

  1. A changelog file needs to be added.
    A new file named 26828.txt should be placed in the changelog directory with the following contents:
```release-note:improvement
secrets/database: Add support for GCP CloudSQL private IP's.
```
  1. Documentation updates are needed.
    The "Configure connection" section of the API docs located here will need to be updated to include this new configuration field. That file is located at website/content/api-docs/secret/databases/postgresql.mdx

    The Setup portion of the "Authenticating to Cloud DBs via IAM" section of the feature documentation located here will need to be updated to include its use. This can be as simple as adding a new line to both CLI command examples to say use_private_ip="false". That file is located at website/content/docs/secrets/databases/postgresql.mdx.

@KyriosGN0 KyriosGN0 requested a review from a team as a code owner June 22, 2024 13:20
@KyriosGN0
Copy link
Contributor Author

hey @robmonte, Thanks you for the review, i addressed the nit in the code and added the required docs changes

@KyriosGN0
Copy link
Contributor Author

@robmonte could you trigger the tests again ?

@robmonte robmonte modified the milestone: 1.18.0-rc Jun 25, 2024
@robmonte robmonte merged commit 3372a9b into hashicorp:main Jun 25, 2024
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow private ip for cloudsql auth integration
4 participants