VAULT-24050 Fix erroneous warning showing when -address is provided #27265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
biazmoreira
approved these changes
May 30, 2024
| @@ -212,7 +211,7 @@ func (c *BaseCommand) Client() (*api.Client, error) { | |||
| } | |||
|
|
|||
| if c.addrWarning != "" && c.UI != nil { | |||
| if os.Getenv("VAULT_ADDR") == "" { | |||
| if os.Getenv("VAULT_ADDR") == "" && !c.flags.hadAddressFlag { | |||
There was a problem hiding this comment.
What's the difference?
There was a problem hiding this comment.
The left is for the environment variable, the right is for -address :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the
WARNING! VAULT_ADDR and -address unseterror would appear even if-addresswas set. As far as I can tell, this is the best way to solve the issue, as this is where-addressactually gets set. Previous to this, the flag is set as the default.Closes #26294
Closes #27135