Add RedShift Plugin #8144
Closed
Add RedShift Plugin #8144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malnick
force-pushed
the
malnick/redshift-plugin
branch
from
a07929e to
dfe9157
Compare
malnick
force-pushed
the
malnick/redshift-plugin
branch
from
dfe9157 to
fd7bc45
Compare
malnick
commented
Jan 13, 2020
| // Wrap the plugin with middleware to sanitize errors | ||
| dbType := dbplugin.NewDatabaseErrorSanitizerMiddleware(db, db.SecretValues) | ||
| return dbType, nil | ||
| func New(lowercaseUsername bool) func() (interface{}, error) { |
There was a problem hiding this comment.
Can probably remove the lowercase code in here, @briankassouf thoughts?
malnick
force-pushed
the
malnick/redshift-plugin
branch
from
6566624 to
94b0392
Compare
malnick
force-pushed
the
malnick/redshift-plugin
branch
from
ccebefc to
5d999af
Compare
malnick
force-pushed
the
malnick/redshift-plugin
branch
from
5d999af to
8fdddd4
Compare
|
Closing in favor of #8299 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.