Added refine for products and arrows #1416
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7h3kk1d
commented
Nov 3, 2024
| switch (Typ.term_of(Typ.weak_head_normalize(ctx, ana))) { | ||
| | Arrow(_, _) => "fun -> " | ||
| | Prod(tys) => | ||
| "(" ++ StringUtil.repeat(List.length(tys) - 1, ", ") ++ ") " |
There was a problem hiding this comment.
This ends up adding a trailing space but that also seems to happen in the paste case as well.
There was a problem hiding this comment.
We don't want extra parens if we're inside of a function application but I don't know how much it matters.
|
|
|
|
Add case patterns |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1416 +/- ##
==========================================
- Coverage 46.87% 46.82% -0.05%
==========================================
Files 101 101
Lines 10153 10153
==========================================
- Hits 4759 4754 -5
- Misses 5394 5399 +5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.2024-11-03.18-11-46.webm
Fills holes of the arrow type with an empty function and product type with an empty tuple. I'm neutral on name but @thomasporter522 had suggested refine since that's what agda uses.