[stable/redis-ha] Update version of redis-exporter

[naseemkullah]

Special notes for your reviewer:

https://github.com/oliver006/redis_exporter#upgrading-from-0x-to-1x

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/chart])

[DandyDeveloper]

@naseemkullah This seems OK for me. I can't approve for the time being.

The minor version increase may be excessive, but, it's fine.

/lgtm

[k8s-ci-robot]

@DandyDeveloper: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

@naseemkullah This seems OK for me. I can't approve for the time being.

The minor version increase may be excessive, but, it's fine.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[DandyDeveloper]

/assign @ssalaues

[DandyDeveloper]

@naseemkullah I now have the authority to do things with this PR, can you update it? :) I'll get this approved and merged.

[ssalaues]

I haven't had a chance to test this @DandyDeveloper but just be sure to keep in mind that there are breaking changes from the old to the new version of the redis exporter
oliver006/redis_exporter#256

[naseemkullah]

updated to v1.3.0 as this is the latest release

[davidkarlsen]

See https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md "versioning" - maybe add a few words in the readme on upgrading due to breaking changes?

[ssalaues]

@davidkarlsen The problem isn't really having a breaking change and bumping the number. We don't validate this particular functionality in the CI so this would require at least manual testing by the author to start with. Since functionality of the exporter has changed, it may require more than just a version bump of the docker image.

From the breaking changes notes:

However, if you already use the exporter as intended by the Prometheus project and scrape only one instance (and e.g. use the --redis.addr and --redis.password cmd line flags)

We do use it to only scrape one instance (each individual pod has it's own sidecar) but don't use the cmd line flags which is where my concerns are.

@naseemkullah have you tested this out to define the behavior of these changes on the chart or if the chart is even affected by the breaking changes? It's very likely that it still works 100% the same for how it is used in the chart. Does the exporter still work as expected and is still picked up by Prometheus as is?

[pgdagenais]

Hey guys, I have been running v1.3.2 in production since friday and staging for more than a week. I don't think I have seen anything different since the upgrade on my dashboards or alerts. I have not had to change anything to the chart to deploy/upgrade the exporter.

[ssalaues]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DandyDeveloper, naseemkullah, ssalaues

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stable/redis-ha/OWNERS [DandyDeveloper,ssalaues]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pgdagenais]

We should have upgraded the default to the latest version v1.3.2 instead of just v1.3.0

[ssalaues]

Yeah that detail slipped by me. @pgdagenais since you have an open bug fix PR, you could add it as a separate commit with an updated note in the PR message of the fix.

[pgdagenais]

Yes will do!