Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update breaking changes section #4905

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Feb 23, 2025

ref: #4888

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

  • Breaking Changes
    • The Tabs component now uses a revised slot name.
    • A deprecated styling prop has been replaced with a new one for consistency.
    • Directional terms have been updated to support right-to-left layouts.
    • Several selection components no longer accept a particular prop for values.
    • The Spinner component now operates on the client side and requires an explicit directive.
    • Users are advised to update certain internationalization packages to ensure compatibility.

@wingkwong wingkwong added the 📋 Scope : Docs Related to the documentation label Feb 23, 2025
@wingkwong wingkwong added this to the v2.7.3 milestone Feb 23, 2025
Copy link

linear bot commented Feb 23, 2025

Copy link

changeset-bot bot commented Feb 23, 2025

⚠️ No Changeset found

Latest commit: 567f42f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Feb 23, 2025

Walkthrough

The pull request introduces breaking changes in HeroUI version 2.7.0. Notable modifications include renaming the wrapper slot to tabWrapper in the Tabs component, deprecating dateInputClassNames in favor of classNames, and replacing directional properties (left/right) with logical ones (start/end) for RTL support. Additionally, the value prop has been removed from ListboxItem, SelectItem, and AutocompleteItem components, the Spinner component has been converted from a server to a client component (now requiring a use client directive), and users are advised to update certain package versions to ensure compatibility.

Changes

File(s) Change Summary
apps/docs/.../v2.7.0.mdx Documents breaking changes in HeroUI 2.7.0: renamed wrapper to tabWrapper in Tabs; deprecated dateInputClassNames for classNames; replaced left/right with start/end; removed value prop from ListboxItem, SelectItem, and AutocompleteItem; converted Spinner to a client component requiring use client; and advises dependency updates for @internationalized/date (v3.7.0) and @react-aria/i18n (v3.12.5).

Suggested reviewers

  • jrgarciadev

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Feb 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
heroui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2025 5:39am
heroui-sb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2025 5:39am

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
apps/docs/content/blog/v2.7.0.mdx (3)

286-286: Consistency in Bullet Punctuation:
The bullet point for the RTL support update currently ends with a period. For consistency with the other bullet items (which do not use a trailing period), consider removing the period.


287-287: Clarify Component Naming for Value Prop Removal:
To improve clarity and consistency, consider adding an article and using inline code for all component names. For example, you could rewrite this bullet as:

- - `ListboxItem`, `SelectItem` & AutocompleteItem no longer accept a `value` prop.
+ - The `ListboxItem`, `SelectItem`, and `AutocompleteItem` components no longer accept a `value` prop.

288-288: Enhance Clarity in Spinner Component Change:
For grammatical clarity and consistency with other bullets, consider prepending "The" and enclosing the component name in inline code. For example:

- - Spinner component is no longer a server component. If you are using global import, you need to add `use client` directive.
+ - The `Spinner` component is no longer a server component. If you are using a global import, you need to add the `use client` directive.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~288-~288: Loose punctuation mark.
Context: ... for better RTL support. - ListboxItem, SelectItem & AutocompleteItem no long...

(UNLIKELY_OPENING_PUNCTUATION)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0250ced and 567f42f.

📒 Files selected for processing (1)
  • apps/docs/content/blog/v2.7.0.mdx (1 hunks)
🧰 Additional context used
🪛 LanguageTool
apps/docs/content/blog/v2.7.0.mdx

[uncategorized] ~288-~288: Loose punctuation mark.
Context: ... for better RTL support. - ListboxItem, SelectItem & AutocompleteItem no long...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~289-~289: Possible missing article found.
Context: ...Item no longer accept a value prop. - Spinner component is no longer a server compone...

(AI_HYDRA_LEO_MISSING_THE)

🔇 Additional comments (2)
apps/docs/content/blog/v2.7.0.mdx (2)

289-289: Version Bump Instruction for @internationalized/date:
The instruction to upgrade to version 3.7.0 for @internationalized/date is clear and informative.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~289-~289: Possible missing article found.
Context: ...Item no longer accept a value prop. - Spinner component is no longer a server compone...

(AI_HYDRA_LEO_MISSING_THE)


290-290: Version Bump Instruction for @react-aria/i18n:
The guidance to upgrade to version 3.12.5 for @react-aria/i18n is clearly stated and useful for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📋 Scope : Docs Related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants