-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): update breaking changes section #4905
base: main
Are you sure you want to change the base?
Conversation
|
WalkthroughThe pull request introduces breaking changes in HeroUI version 2.7.0. Notable modifications include renaming the Changes
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
apps/docs/content/blog/v2.7.0.mdx (3)
286-286
: Consistency in Bullet Punctuation:
The bullet point for the RTL support update currently ends with a period. For consistency with the other bullet items (which do not use a trailing period), consider removing the period.
287-287
: Clarify Component Naming for Value Prop Removal:
To improve clarity and consistency, consider adding an article and using inline code for all component names. For example, you could rewrite this bullet as:- - `ListboxItem`, `SelectItem` & AutocompleteItem no longer accept a `value` prop. + - The `ListboxItem`, `SelectItem`, and `AutocompleteItem` components no longer accept a `value` prop.
288-288
: Enhance Clarity in Spinner Component Change:
For grammatical clarity and consistency with other bullets, consider prepending "The" and enclosing the component name in inline code. For example:- - Spinner component is no longer a server component. If you are using global import, you need to add `use client` directive. + - The `Spinner` component is no longer a server component. If you are using a global import, you need to add the `use client` directive.🧰 Tools
🪛 LanguageTool
[uncategorized] ~288-~288: Loose punctuation mark.
Context: ... for better RTL support. -ListboxItem
,SelectItem
& AutocompleteItem no long...(UNLIKELY_OPENING_PUNCTUATION)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/docs/content/blog/v2.7.0.mdx
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
apps/docs/content/blog/v2.7.0.mdx
[uncategorized] ~288-~288: Loose punctuation mark.
Context: ... for better RTL support. - ListboxItem
, SelectItem
& AutocompleteItem no long...
(UNLIKELY_OPENING_PUNCTUATION)
[uncategorized] ~289-~289: Possible missing article found.
Context: ...Item no longer accept a value
prop. - Spinner component is no longer a server compone...
(AI_HYDRA_LEO_MISSING_THE)
🔇 Additional comments (2)
apps/docs/content/blog/v2.7.0.mdx (2)
289-289
: Version Bump Instruction for @internationalized/date:
The instruction to upgrade to version3.7.0
for@internationalized/date
is clear and informative.🧰 Tools
🪛 LanguageTool
[uncategorized] ~289-~289: Possible missing article found.
Context: ...Item no longer accept avalue
prop. - Spinner component is no longer a server compone...(AI_HYDRA_LEO_MISSING_THE)
290-290
: Version Bump Instruction for @react-aria/i18n:
The guidance to upgrade to version3.12.5
for@react-aria/i18n
is clearly stated and useful for users.
ref: #4888
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit