-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBW-80 Limit on the number of choices in lookup select #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd like to limit results in query like before to prevent:
- fetching many rows from DB;
- instantiating many objects for unnecessary items.
You need to pass MAX_ROW_COUNT
deeper to loader
and cut result set just after filtering.
2552088
to
e78a34d
Compare
Updated |
@@ -1,7 +1,7 @@ | |||
module HBW | |||
module Sources | |||
class Activiti < Base | |||
def select(variable_name, variables) | |||
def select(variable_name, variables, limit = nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't use it then rename variable to _
86f8b6b
to
73e4109
Compare
Updated |
No description provided.