HBW-349 Generate unique id for file_upload compoment #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodor85
force-pushed
the
HBW-349
branch
3 times, most recently
from
a6152c5 to
fca1a48
Compare
TimAle
requested changes
Jun 15, 2021
CHANGELOG.md
Outdated
Comment on lines
8
to
9
| ### Features | ||
| - [#563](https://github.com/latera/homs/pull/563) Generate unique id for file_upload compoment |
There was a problem hiding this comment.
Suggested change
| ### Features | |
| - [#563](https://github.com/latera/homs/pull/563) Generate unique id for file_upload compoment | |
| ### Bugfixes | |
| - [#563](https://github.com/latera/homs/pull/563) Generate unique id for file_upload compoment. |
| @@ -80,11 +81,12 @@ modulejs.define('HBWFormFileUpload', ['React'], (React) => { | |||
| } = this.props; | |||
|
|
|||
| const { isDragActive } = this.state; | |||
| const fileInputID = uuidv4(); | |||
There was a problem hiding this comment.
I think there is no need to generate it on every render, make it a component property.
Comment on lines
79
to
80
| preview_another = page.all('.files-preview-row')[0] | ||
| form_group = page.all('.form-group')[0] |
Comment on lines
81
to
83
| file_input = form_group.find_field('homsOrderDataUploadedFileAnother', type: :file, visible: :hidden) | ||
|
|
||
| expect(file_input['name']).to eq('homsOrderDataUploadedFileAnother') |
There was a problem hiding this comment.
You have found this field by name, so you're testing Capybara now. Don't do that)
Comment on lines
85
to
98
| expect(preview_another).to have_content 'logo.svg' | ||
| expect(preview_another).to have_content 'file.txt' | ||
| expect(preview_another).to have_content 'file_with...me.pdf' |
There was a problem hiding this comment.
I think you should do something equivalent to your gif: attach files to both inputs in the same test.
theodor85
force-pushed
the
HBW-349
branch
2 times, most recently
from
e7dd00a to
24d3170
Compare
TimAle
requested changes
Jun 16, 2021
TimAle
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uploading multiple files into different
file_uploadfields works correctly:As "Id"
uuidis used: