This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Fix send tx sequence method #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kamilsa <[email protected]>
Signed-off-by: kamilsa <[email protected]>
vdrobnyi
approved these changes
Aug 28, 2018
l4l
reviewed
Aug 29, 2018
| bar.wait(); | ||
| { | ||
| std::unique_lock<std::mutex> lk(m); | ||
| cv.wait(lk, [&] { return processed; }); |
There was a problem hiding this comment.
That will wait forever, if notify_all is called before
There was a problem hiding this comment.
Why? This is equivalent to while (!pred()) { wait(lock); }, so it will unlock after the observable is completed.
Edit: it will wait forever indeed because it will not be woken up
lebdron
suggested changes
Aug 30, 2018
| @@ -279,7 +286,10 @@ namespace integration_framework { | |||
| tx_list); | |||
|
|
|||
| // make sure that the first (stateless) status is come | |||
| bar.wait(); | |||
| { | |||
| @@ -265,7 +268,11 @@ namespace integration_framework { | |||
| statuses.push_back(*std::static_pointer_cast< | |||
| shared_model::proto::TransactionResponse>(s)); | |||
| }, | |||
| [&bar] { bar.wait(); }); | |||
| [&cv, &m, &processed] { | |||
| std::lock_guard<std::mutex> lock(m); | |||
There was a problem hiding this comment.
lock seems redundant here, what is its purpose? processed cannot be modified concurrently because on_complete is called once only.
There was a problem hiding this comment.
According to https://en.cppreference.com/w/cpp/thread/condition_variable it is needed
Signed-off-by: kamilsa <[email protected]>
kamilsa
force-pushed
the
fix/itf-send-tx-sequence
branch
from
3aa5f29 to
4a30e0e
Compare
lebdron
approved these changes
Aug 31, 2018
|
SonarQube analysis reported 1 issue
|
bakhtin
pushed a commit
that referenced
this pull request
Nov 2, 2018
* Fix send tx sequence method Signed-off-by: kamilsa <[email protected]> * Add lock guard Signed-off-by: kamilsa <[email protected]> * Remove scope Signed-off-by: kamilsa <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kamilsa [email protected]
Description of the Change
Due to unclear reasons boost::barrier throws segfault in send tx sequence test (once out from 100 runs on average). To avoid that it was replaced with std::condition_variable.
Benefits
No segfaults are thrown anymore(test was executed ~2000 times)
Possible Drawbacks
Inconsistency with
sendTxmethod which still usesboost::barrier