This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Ordering service fuzzing #1829
Merged
Ordering service fuzzing #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luckychess <[email protected]>
Signed-off-by: luckychess <[email protected]>
Closed
l4l
suggested changes
Nov 3, 2018
| std::shared_ptr<OnDemandOsServerGrpc> server_; | ||
|
|
||
| auto proposal_factory = std::make_unique<MockUnsafeProposalFactory>(); | ||
| ordering_service_ = std::make_shared<OnDemandOrderingServiceImpl>(data[0], std::move(proposal_factory)); |
There was a problem hiding this comment.
transaction_limithassize_t, so it might be better give at least 2 bytes, instead of one- there's
number_of_proposalsthat also might be fuzzed - might be
initial_roundis also applicable for a fuzzing as well, though not sure
Same for the next test
There was a problem hiding this comment.
Well, i thought about it. In my opinion the main purpose of fuzzing is to find ways how iroha could be broken via some malicious input. That means a typical ordering gate under attack will probably be initialised with more or less default parameter values.
Feel free to discuss though.
Akvinikym
suggested changes
Nov 4, 2018
l4l
added
needs-correction
Signed-off-by: luckychess <[email protected]>
Signed-off-by: luckychess <[email protected]>
Signed-off-by: luckychess <[email protected]>
l4l
approved these changes
Nov 6, 2018
| #include <gtest/gtest.h> | ||
| #include <libfuzzer/libfuzzer_macro.h> | ||
| #include "ordering/impl/on_demand_ordering_service_impl.hpp" | ||
| #include <memory> |
There was a problem hiding this comment.
and again wrong :( use this:
#include <memory>
#include <gtest/gtest.h>
#include <libfuzzer/libfuzzer_macro.h>
#include "backend/protobuf/proto_transport_factory.hpp"
...
Akvinikym
approved these changes
Nov 7, 2018
Signed-off-by: luckychess <[email protected]>
igor-egorov
pushed a commit
that referenced
this pull request
Nov 12, 2018
* Add OS fuzzing for SendBatches endpoint * Add fuzzing for request proposal endpoint Signed-off-by: luckychess <[email protected]> Signed-off-by: Konstantin Munichev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This pull request adds 2 fuzzing targets for ordering service endpoints.
Benefits
One more possibility to find bugs and issues in the code.
Possible Drawbacks
Hard to support until we have fuzzing in CI.
Usage Examples or Tests