Apply suggestions from code review

/build all
hyperledger-iroha · Aug 23, 2021 · 5dea34b · 5dea34b
1 parent 7fb3865
commit 5dea34b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/example/config.sample b/example/config.sample
@@ -1,5 +1,4 @@
 {
-  "block_store_path": "/tmp/block_store/",
   "torii_port": 50051,
   "internal_port": 10001,
   "database": {

diff --git a/irohad/ametsuchi/impl/rocksdb_common.hpp b/irohad/ametsuchi/impl/rocksdb_common.hpp
@@ -376,9 +376,6 @@ namespace iroha::ametsuchi::fmtstrings {
 
 }  // namespace iroha::ametsuchi::fmtstrings
 
-#undef RDB_PATH_DOMAIN
-#undef RDB_PATH_ACCOUNT
-#undef RDB_ITEM
 
 namespace {
   auto constexpr kValue{FMT_STRING("{}")};
@@ -1022,7 +1019,7 @@ namespace iroha::ametsuchi {
             typename T,
             typename = std::enable_if_t<std::is_same<T, bool>::value>>
   inline std::optional<bool> loadValue(
-      RocksDbCommon & /*common*/,
+      RocksDbCommon&,
       expected::Result<rocksdb::Status, DbError> const &status) {
     std::optional<bool> value;
     if constexpr (kOp == kDbOperation::kGet) {

diff --git a/libs/common/result.hpp b/libs/common/result.hpp
@@ -445,9 +445,7 @@ namespace iroha {
         typename std::enable_if<not std::is_same<decltype(f()), void>::value,
                                 ReturnType>::type {
       return r.match(
-          [&f](const Value<T> &) {
-            return TypeHelper::makeValue(f());
-          },
+          [&f](const Value<T> &) { return TypeHelper::makeValue(f()); },
           [](const Error<E> &e) { return ReturnType(makeError(e.error)); });
     }