Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warnings for unreasonable settings in configs #2801

Open
ilchu opened this issue Sep 29, 2022 · 1 comment
Open

Add warnings for unreasonable settings in configs #2801

ilchu opened this issue Sep 29, 2022 · 1 comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@ilchu
Copy link
Contributor

ilchu commented Sep 29, 2022 •
edited
Loading

As mentioned here, some of the user configuration settings for genesis and other parts could be legal, but possibly not what the user actually wants, leading to an unfavorably high tx rejection rate or other problems. To avoid this, we need to identify such points and properly warn the user (presumably in each config's finish() method).
@ilchu ilchu added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 29, 2022
@ilchu ilchu mentioned this issue Sep 29, 2022
Merged
@mversic
Copy link
Contributor

mversic commented Aug 23, 2023

related to #2585

@0x009922 0x009922 mentioned this issue Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilchu @mversic