-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #2712: Config proptests #2770
Conversation
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #2770 +/- ##
==============================================
- Coverage 67.61% 66.09% -1.53%
==============================================
Files 140 166 +26
Lines 26173 30222 +4049
==============================================
+ Hits 17696 19974 +2278
- Misses 8477 10248 +1771
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1444c86
to
80a0229
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the first steps in direction of property based testing.
IMO if done right (especially something like stateful-testsing) it could help us to find bugs that would be hard to find otherwise.
John Hughes has great talks on this topic.
@Erigara @ilchu Just a vocabulary note. The word Can we come up with a different word? For example: |
80a0229
to
b7c118d
Compare
3e49b9b
to
9f0aa0e
Compare
332cc53
to
09aac50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ilia Churin <[email protected]>
09aac50
to
1159a61
Compare
Description of the Change
ConfigurationProxy
structsconfig.json
to allow them to be built from proxies immediately upon readingIssue
Closes #2712.
Benefits
More confidence in current proxy implementation's robustness.
Possible Drawbacks
I've struggled a bit with a generation strategy that would be compact yet showing the intended invariant, so I hope nothing's missing.
Usage Examples or Tests
cargo test --package iroha_config --lib -- iroha::tests client::tests --nocapture
Alternate Designs [optional]