-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suggestion] Make a query builder and remove the boilerplate request_with_*
methods
#3124
Comments
Good idea. Let's make sure we cover all of the patterns in the code. |
Another suggestion is to use "default parameters". |
Personally, this is up for debate. The builder pattern is common-enough in our code base not to surprise new users. While in a vacuum I'd prefer having a struct and use the @Erigara unless you have a preference for Default ellipses, I'd consider using the builder pattern as described in the issue. |
@appetrosyan @pesterev i don't insist on |
…nto Client API Signed-off-by: Vladimir Pesterev <[email protected]>
…nto Client API Signed-off-by: Vladimir Pesterev <[email protected]>
…nto Client API Signed-off-by: Vladimir Pesterev <[email protected]>
…nto Client API Signed-off-by: Vladimir Pesterev <[email protected]>
…nto Client API Signed-off-by: Vladimir Pesterev <[email protected]>
…nto Client API Signed-off-by: Vladimir Pesterev <[email protected]>
…nto Client API Signed-off-by: Vladimir Pesterev <[email protected]>
Signed-off-by: Vladimir Pesterev <[email protected]>
Feature request
My suggestion is to make a builder and to get rid of these
Client
'srequest_with_*
methods.Motivation
We have many boilerplate
Client
's query methods.Who can help?
@appetrosyan @pesterev
The text was updated successfully, but these errors were encountered: