Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a macro to remove bloat from custom validators #3856

Closed
mversic opened this issue Aug 31, 2023 · 1 comment
Closed

Write a macro to remove bloat from custom validators #3856

mversic opened this issue Aug 31, 2023 · 1 comment
Assignees
@ilchu @alexstroke1
Labels
high-priority This bug must be fixed ASAP iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Aug 31, 2023

If one compares different validators in tests, one can see there is a lot of bloat that one has to write to make a custom validator. Let's remove this difficult and confusing manual effort from the user by providing a macro
@mversic mversic added high-priority This bug must be fixed ASAP iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Aug 31, 2023
@mversic
Copy link
Contributor Author

mversic commented Aug 31, 2023

Apply this macro in default_validator crate and all crates in client/tests/integration/smartcontracts

@mversic mversic mentioned this issue Aug 31, 2023
Merged
5 tasks
@ilchu ilchu self-assigned this Sep 4, 2023
@DCNick3 DCNick3 assigned DCNick3 and unassigned DCNick3 Sep 4, 2023
ilchu added a commit to ilchu/iroha that referenced this issue Sep 18, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
bb681ad 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit to ilchu/iroha that referenced this issue Sep 18, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
b5be921 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit to ilchu/iroha that referenced this issue Sep 18, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
aba342d 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>
@ilchu ilchu mentioned this issue Sep 18, 2023
Merged
4 tasks
ilchu added a commit to ilchu/iroha that referenced this issue Sep 18, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
045d744 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit to ilchu/iroha that referenced this issue Oct 19, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
94e7c90 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit to ilchu/iroha that referenced this issue Oct 24, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
f226205 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit to ilchu/iroha that referenced this issue Oct 25, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
127ab9f 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit to ilchu/iroha that referenced this issue Oct 27, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
bf1d88d 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
mversic pushed a commit to ilchu/iroha that referenced this issue Oct 31, 2023
@ilchu @mversic
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
956ef2a 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit to ilchu/iroha that referenced this issue Nov 4, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
0de8cdd 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit to ilchu/iroha that referenced this issue Nov 4, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
1cb58ad 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
mversic pushed a commit to ilchu/iroha that referenced this issue Nov 6, 2023
@ilchu @mversic
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
49afb8b 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit to ilchu/iroha that referenced this issue Nov 8, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
6d9274b 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit to ilchu/iroha that referenced this issue Nov 9, 2023
@ilchu
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
c629f80 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit that referenced this issue Nov 9, 2023
@ilchu
[refactor] #3856: Proc macro for default validator boilerplate
8860376 
Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
mversic pushed a commit to mversic/iroha that referenced this issue Nov 13, 2023
@ilchu @mversic
[refactor] hyperledger-iroha#3856: Proc macro for default validator b…
75dfcf4 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
ilchu added a commit to ilchu/iroha that referenced this issue Nov 13, 2023
@ilchu
[BACKPORT] hyperledger-iroha#3856: Proc macro for default validator b…
1095e3b 
…oilerplate

Signed-off-by: Ilia Churin <[email protected]>

[fix] Missing doc lints

Signed-off-by: Ilia Churin <[email protected]>

[refactor] Migrating to derive macros

Signed-off-by: Ilia Churin <[email protected]>
mversic added a commit that referenced this issue Nov 13, 2023
@mversic @ilchu
[BACKPORT] #3856: Proc macro for default executor boilerplate (#4051)
6f54d83 
Co-authored-by: Ilia Churin <[email protected]>
@AlexStroke AlexStroke self-assigned this Nov 24, 2023
@alexstroke1 alexstroke1 assigned alexstroke1 and unassigned AlexStroke Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilchu ilchu

@alexstroke1 alexstroke1

Labels
high-priority This bug must be fixed ASAP iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DCNick3 @ilchu @mversic @AlexStroke @alexstroke1