Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune usage of V1 structs from codebase #3887

Closed
mversic opened this issue Sep 13, 2023 · 1 comment
Closed

Prune usage of V1 structs from codebase #3887

mversic opened this issue Sep 13, 2023 · 1 comment
Assignees
@Stukalov-A-M
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Sep 13, 2023

Let's see to what extent can we rewrite the code (source code or tests) that destructures versioned enum into a concrete type:

  • for example VersionedSignedBlock::V1 must not be used except in data_model
  • no code outside of data_model should depend on a specific version
@mversic mversic added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 13, 2023
@Stukalov-A-M Stukalov-A-M self-assigned this Jan 29, 2024
@Stukalov-A-M
Copy link
Contributor

To hide internal structure of versioning structs from external users and a public API.
To keep access for internal crates.

Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Jan 31, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
a46a862 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Jan 31, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
af3ae26 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Jan 31, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
222a41b 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Jan 31, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
6dd734e 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
@Stukalov-A-M Stukalov-A-M mentioned this issue Jan 31, 2024
Closed
5 tasks
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 2, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
20df86b 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 2, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
bed5dd9 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
@Stukalov-A-M Stukalov-A-M mentioned this issue Feb 2, 2024
Merged
5 tasks
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 5, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
9a98c14 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 7, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
b77af40 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 8, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
10549b3 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 8, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
fd22600 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 8, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
fa0acb2 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 8, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
c6d9a61 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 12, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
c9b7585 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 12, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
93e8567 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 12, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
2367ed1 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 13, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
435a93c 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 13, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
53bc744 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 13, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
d6330c9 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 13, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
4353370 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 13, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
fa89439 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 13, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
d34abba 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit to Stukalov-A-M/iroha that referenced this issue Feb 13, 2024
@Stukalov-A-M
[refactor] hyperledger-iroha#3887 Hide an internal structure of the v…
41977be 
…ersioned structs from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Stukalov-A-M added a commit that referenced this issue Feb 13, 2024
@Stukalov-A-M
[refactor] #3887 Hide an internal structure of the versioned structs …
7501abe 
…from the public API.

Signed-off-by: Stukalov-A-M <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stukalov-A-M Stukalov-A-M

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mversic @Stukalov-A-M