Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[optimization] Executor: validate by value, not by reference #4082

Closed
Arjentix opened this issue Nov 24, 2023 · 0 comments
Closed

[optimization] Executor: validate by value, not by reference #4082

Arjentix opened this issue Nov 24, 2023 · 0 comments
Assignees
@mversic
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should Refactor Improvement to overall code quality

Comments

@Arjentix
Copy link
Contributor

Currently Executor entrypoint functions get all parameters by value. But then validate them by reference because of Visit trait. This causes some extra clonning.

This problem can be avoided. Probably need to reconsider Visit trait. Especially after #3941
@Arjentix Arjentix added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality Optimization Something isn't working as well as it should labels Nov 24, 2023
@Arjentix Arjentix changed the title [optimisation] Executor: validate by value, not by reference [optimization] Executor: validate by value, not by reference Nov 24, 2023
mversic added a commit to mversic/iroha that referenced this issue Jan 4, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
6c7d506 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Jan 4, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
cf65d44 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Jan 4, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
6645096 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Jan 4, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
328b46c 
Signed-off-by: Marin Veršić <[email protected]>
@mversic mversic mentioned this issue Jan 4, 2024
Merged
5 tasks
mversic added a commit to mversic/iroha that referenced this issue Jan 4, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
7955873 
Signed-off-by: Marin Veršić <[email protected]>
@mversic mversic self-assigned this Jan 4, 2024
mversic added a commit to mversic/iroha that referenced this issue Jan 9, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
4beb873 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Jan 9, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
d545717 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Jan 10, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
e059f67 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Jan 10, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
c43a409 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Jan 10, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
e5f062a 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Jan 10, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
c09ebae 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 16, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
838e7ff 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 16, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
133b5c5 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 19, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
a9e2796 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 19, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
7e791a1 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 19, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
9f25fdd 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 19, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
1ee30ff 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 19, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
a994805 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 19, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
f4aa95e 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 19, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
e938711 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 19, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
fe62267 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 19, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
e53f58d 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 19, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
11b11a5 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 20, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
25709a5 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 20, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
d4364fa 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 20, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
6477a6c 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 20, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
f9b97d2 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 20, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
e28c6f8 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 20, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
6c5d379 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 20, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
fbf7c06 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 26, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
0fceac5 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 26, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
827643e 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 26, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
46208d0 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 26, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
55a33e6 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 26, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
2b2c6d6 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 26, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
5c1b523 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 27, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
45b2873 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 27, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for ISI execution in wasm
263111d 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit to mversic/iroha that referenced this issue Feb 27, 2024
@mversic
[fix] hyperledger-iroha#4082: Remove cloning for query execution in wasm
4e33466 
Signed-off-by: Marin Veršić <[email protected]>
mversic added a commit that referenced this issue Feb 28, 2024
@mversic
[fix] #4082: Remove cloning for ISI and query execution in wasm (#4182)
fd09f10 
* [fix] #4082: Remove cloning for ISI execution in wasm
* [fix] #4082: Remove cloning for query execution in wasm

Signed-off-by: Marin Veršić <[email protected]>
@DCNick3 DCNick3 closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mversic mversic

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DCNick3 @Arjentix @mversic