Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Trigger atomicity is broken #4106

Closed
Erigara opened this issue Nov 30, 2023 · 2 comments
Closed

[BUG]: Trigger atomicity is broken #4106

Erigara opened this issue Nov 30, 2023 · 2 comments
Assignees
@Erigara @timofeevmd @alexstroke1
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix

Comments

@Erigara
Copy link
Contributor

Erigara commented Nov 30, 2023

Atm we don't have trigger atomicity, tirgger can fail and still change state in some way.
@Erigara Erigara added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Nov 30, 2023
@Erigara Erigara self-assigned this Nov 30, 2023
Erigara added a commit to Erigara/iroha that referenced this issue Nov 30, 2023
@Erigara
[fix] hyperledger-iroha#4106: Fix trigger atomicity
fed0e01 
Signed-off-by: Shanin Roman <[email protected]>
@Erigara Erigara mentioned this issue Nov 30, 2023
Merged
Erigara added a commit that referenced this issue Nov 30, 2023
@Erigara
[fix] #4106: Fix trigger atomicity
69159af 
Signed-off-by: Shanin Roman <[email protected]>
@Mingela
Copy link
Contributor

Mingela commented Dec 7, 2023

@Erigara should this be closed?

@Erigara
Copy link
Contributor Author

Erigara commented Dec 7, 2023

@Mingela i moved this to verify column in zenhub, so our QA team could verify ticket.

@AlexStroke AlexStroke self-assigned this Dec 8, 2023
@timofeevmd timofeevmd added the QA-confirmed This bug is reproduced and needs a fix label Dec 12, 2023
@timofeevmd timofeevmd self-assigned this Dec 12, 2023
@alexstroke1 alexstroke1 assigned alexstroke1 and unassigned AlexStroke Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

@timofeevmd timofeevmd

@alexstroke1 alexstroke1

Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Mingela @Erigara @timofeevmd @AlexStroke @alexstroke1