Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate why signature::secp256k1::test::secp256k1_sign test from iroha_crypto is flaky #4155

Closed
DCNick3 opened this issue Dec 15, 2023 · 0 comments
Closed

Investigate why signature::secp256k1::test::secp256k1_sign test from iroha_crypto is flaky #4155

DCNick3 opened this issue Dec 15, 2023 · 0 comments
Assignees
@DCNick3
Labels
crypto iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests

Comments

@DCNick3
Copy link
Contributor

DCNick3 commented Dec 15, 2023

Sometimes the signature verification is failing, we should investigate why
@DCNick3 DCNick3 added iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests labels Dec 15, 2023
@DCNick3 DCNick3 self-assigned this Dec 15, 2023
DCNick3 added a commit to DCNick3/iroha that referenced this issue Dec 25, 2023
@DCNick3
[fix] hyperledger-iroha#4155: ensure the secp256k1 signatures coming …
883bdf2 
…out of OpenSSL are normalized

This is an interoperability problem between OpenSSL and newer cryptographic libraries, see [https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#user-content-Low_S_values_in_signatures)[BIP-0062] for details

This fixes the flaky secp256k1_sign test

Also includes a drive-by cleanup of useless `assert(result.is_ok())`

Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 DCNick3 mentioned this issue Dec 25, 2023
Merged
1 task
DCNick3 added a commit to DCNick3/iroha that referenced this issue Dec 25, 2023
@DCNick3
[fix] hyperledger-iroha#4155: ensure the secp256k1 signatures coming …
50ffbd3 
…out of OpenSSL are normalized

This is an interoperability problem between OpenSSL and newer cryptographic libraries, see [https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#user-content-Low_S_values_in_signatures)[BIP-0062] for details

This fixes the flaky secp256k1_sign test

Also includes a drive-by cleanup of useless `assert(result.is_ok())`

Signed-off-by: Nikita Strygin <[email protected]>
DCNick3 added a commit that referenced this issue Dec 25, 2023
@DCNick3
[fix] #4155: ensure the secp256k1 signatures coming out of OpenSSL ar…
4091454 
…e normalized

This is an interoperability problem between OpenSSL and newer cryptographic libraries, see [https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#user-content-Low_S_values_in_signatures)[BIP-0062] for details

This fixes the flaky secp256k1_sign test

Also includes a drive-by cleanup of useless `assert(result.is_ok())`

Signed-off-by: Nikita Strygin <[email protected]>
@DCNick3 DCNick3 closed this as completed Jan 9, 2024
@DCNick3 DCNick3 added the crypto label Jan 10, 2024
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this issue Jan 22, 2024
@DCNick3 @Asem-Abdelhady
[fix] hyperledger-iroha#4155: ensure the secp256k1 signatures coming …
1736cbb 
…out of OpenSSL are normalized

This is an interoperability problem between OpenSSL and newer cryptographic libraries, see [https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#user-content-Low_S_values_in_signatures)[BIP-0062] for details

This fixes the flaky secp256k1_sign test

Also includes a drive-by cleanup of useless `assert(result.is_ok())`

Signed-off-by: Nikita Strygin <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this issue Feb 9, 2024
@DCNick3 @Asem-Abdelhady
[fix] hyperledger-iroha#4155: ensure the secp256k1 signatures coming …
f7af818 
…out of OpenSSL are normalized

This is an interoperability problem between OpenSSL and newer cryptographic libraries, see [https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#user-content-Low_S_values_in_signatures)[BIP-0062] for details

This fixes the flaky secp256k1_sign test

Also includes a drive-by cleanup of useless `assert(result.is_ok())`

Signed-off-by: Nikita Strygin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DCNick3 DCNick3

Labels
crypto iroha2-dev The re-implementation of a BFT hyperledger in RUST Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DCNick3