-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] iroha_client 401 HTTP Response after executing get_config_value method #4177
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Comments
Discussed with Daniil and Dmitriy that it's not safety to refactor request builder because current design provides a generic property for other request builders like ActixReqBuilder. |
Stukalov-A-M
added a commit
to Stukalov-A-M/iroha
that referenced
this issue
Dec 28, 2023
…Client's headers to the requests Signed-off-by: Stukalov-A-M <[email protected]>
5 tasks
Stukalov-A-M
added a commit
to Stukalov-A-M/iroha
that referenced
this issue
Dec 28, 2023
…Client's headers to the requests Signed-off-by: Stukalov-A-M <[email protected]>
Arjentix
pushed a commit
to Stukalov-A-M/iroha
that referenced
this issue
Jan 12, 2024
…Client's headers to the requests Signed-off-by: Stukalov-A-M <[email protected]>
Arjentix
pushed a commit
that referenced
this issue
Jan 12, 2024
…to the requests Signed-off-by: Stukalov-A-M <[email protected]>
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Jan 22, 2024
…Client's headers to the requests Signed-off-by: Stukalov-A-M <[email protected]> Signed-off-by: Asem-Abdelhady <[email protected]>
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this issue
Feb 9, 2024
…Client's headers to the requests Signed-off-by: Stukalov-A-M <[email protected]>
Fixed by #4180. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It happens because method doesn't pass Authorization header to the Request builder.
Also we are using both attohttpc and http crates for building HTTP requests, that creates code excessiveness and in some cases ambiguousness.As an example - building a request through request body check.
For this reason, in the process of the bug fixing, I propose to refactor by removing the attohttpc crate from client and unify all HTTP request building using the http crate only.The text was updated successfully, but these errors were encountered: