Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent registering genesis Domain or Account #4226

Closed
mversic opened this issue Jan 23, 2024 · 1 comment
Closed

Prevent registering genesis Domain or Account #4226

mversic opened this issue Jan 23, 2024 · 1 comment
Assignees
@dima74 @alexstroke1
Labels
Bug Something isn't working good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@mversic
Copy link
Contributor

mversic commented Jan 23, 2024

We have to make sure that instructions that try to register "genesis" domain or "genesis@genesis" account are always rejected. Tests should be added as well. Additionally, if there are none, tests should be added that confirm that any transaction signed by the "genesis@genesis" is rejected
@mversic mversic added good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Bug Something isn't working labels Jan 23, 2024
@dima74 dima74 self-assigned this Apr 11, 2024
dima74 added a commit that referenced this issue Apr 12, 2024
@dima74
[fix] #4226: Prevent registering genesis Domain or Account
14593e4 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74 dima74 mentioned this issue Apr 12, 2024
Merged
5 tasks
dima74 added a commit that referenced this issue Apr 15, 2024
@dima74
[fix] #4226: Prevent registering genesis Domain or Account
90ec4cd 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74
Copy link
Contributor

dima74 commented Apr 15, 2024

Fixed in #4427

@dima74 dima74 closed this as completed Apr 15, 2024
@dima74 dima74 reopened this Apr 15, 2024
@AlexStroke AlexStroke self-assigned this Apr 16, 2024
@alexstroke1 alexstroke1 assigned alexstroke1 and unassigned AlexStroke Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dima74 dima74

@alexstroke1 alexstroke1

Labels
Bug Something isn't working good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dima74 @mversic @AlexStroke @alexstroke1