-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove MST aggregation from iroha #4229
Comments
If this issue is closed as not planned and we decide not to remove |
also remove |
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
I don't think it's too late to remove one feature after coming up with an alternative implementation. I agree with stopping transactions pending in the queue because, if my memory is correct, at some point the queue became a performance bottleneck and its simplification might help. Instead, now that we have triggers, I think it is possible to implement multi-signature transaction proposal as a trigger registration, and approval for it as a voting instruction targeting the trigger. This approach is similar to that of Polkadot.
Anyway, multi-signature is a common feature and we'd better consider alternatives |
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
Signed-off-by: Stukalov-A-M <[email protected]>
I think we should remove aggregation of MST signatures out of Iroha. Transaction signing should happen outside Iroha and only after all signatures have been collected should it be submitted to Iroha
This would also mean that we should remove
pending_transactions
endpointThe text was updated successfully, but these errors were encountered: