Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] incorrect metric connected_peers with istio service mesh #4267

Closed
timofeevmd opened this issue Feb 7, 2024 · 3 comments
Closed

[BUG] incorrect metric connected_peers with istio service mesh #4267

timofeevmd opened this issue Feb 7, 2024 · 3 comments
Assignees
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix

Comments

@timofeevmd
Copy link
Contributor

OS and Environment

Linux, K8s

GIT commit hash

eca8569

Minimum working example / Steps to reproduce

  1. Raise five peers in Kubernetes
  2. Istio must be turned off
  3. Metric connected_peers = 4 on all peers
  4. Turn on istio, restart the pods. Metric connected_peers = 4
  5. Restart the pods again.
  6. Check the metric for peer0, peer1, peer4 connected_peers = 4,
  7. Check the connected_peers metric for peer2 and peer3. It should be equal to connected_peers = 3.

Peculiarities

  1. There are no errors in the logs related to the connection between peers
  2. Go to peer 3 (where connected_peers = 3), make a transaction - it should receive commit status.
  3. We go to another peer, for example peer1, where connected_peers = 4 - the transaction should be displayed in this peer

2024-02-07 17 56 07

2024-02-07 17 56 17

2024-02-07 17 56 21

2024-02-07 17 56 25

Actual result

The metric for peer0, peer1, peer4 connected_peers = 4,
The connected_peers metric for peer2 and peer3. It should be equal to connected_peers = 3.

Expected result

The metric connected_peers should be equal 4 in all peers

Logs in JSON format

Log contents
see attachments

Who can help to reproduce?

@BAStos525

Notes

No response

@timofeevmd timofeevmd added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Feb 7, 2024
@github-project-automation github-project-automation bot moved this to Todo in Iroha 2.0 Feb 7, 2024
@BAStos525
Copy link
Contributor

We also can see this metric dashboard in Grafana for internal usage (DM me).

@Erigara
Copy link
Contributor

Erigara commented Feb 12, 2024

Let's check first that it's metric issue and not smt with connectivity.
Provided instructions to @BAStos525 how to check this.

@BAStos525
Copy link
Contributor

BAStos525 commented Feb 21, 2024

  1. Check on iroha environment, where there are four peers in docker containers on different machines. Correct connected_peers metric value. I substitute the domain addresses of machines from trusted peer config file, the message is not sent to nc. It is also not sent via the IP addresses of the machines.
  2. At another stand, where all four peers are in a container on one machine. Correct connected_peers metric value. They are on the same docker network, so I use the names of the containers, and the message comes.
  3. k8s deployment, where istio is enabled. Wrong connected_peers metric value. Responses via nc come through the FQDN of the pods, as well as through the local peer addresses or peer service addresses.

Erigara added a commit to Erigara/iroha that referenced this issue Mar 29, 2024
Erigara added a commit to Erigara/iroha that referenced this issue Apr 3, 2024
Erigara added a commit to Erigara/iroha that referenced this issue Apr 3, 2024
Erigara added a commit to Erigara/iroha that referenced this issue Apr 3, 2024
Erigara added a commit to Erigara/iroha that referenced this issue Apr 3, 2024
Erigara added a commit to Erigara/iroha that referenced this issue Apr 4, 2024
Erigara added a commit to Erigara/iroha that referenced this issue Apr 5, 2024
Erigara added a commit that referenced this issue Apr 5, 2024
@timofeevmd timofeevmd added the QA-confirmed This bug is reproduced and needs a fix label Apr 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Iroha 2.0 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST QA-confirmed This bug is reproduced and needs a fix
Projects
None yet
Development

No branches or pull requests

6 participants