Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize non-empty blocks by proactively creating the next block, even if it is empty #5317

Open
s8sato opened this issue Feb 14, 2025 · 0 comments · May be fixed by #5320
Open

Finalize non-empty blocks by proactively creating the next block, even if it is empty #5317

s8sato opened this issue Feb 14, 2025 · 0 comments · May be fixed by #5320
Assignees
Labels
Bug Something isn't working Consensus This issue is related to the Sumeragi consensus

Comments

@s8sato
Copy link
Contributor

s8sato commented Feb 14, 2025

I don’t ask for crypto. M◉⃤|<𓊖༒𓊖 Takemiya 武宮誠 (Sora.org & SORAMITSU), [2025/02/14 2:59]
Looking at http://s1.dev.iroha2.iroha.tech:8080, it seems that Iroha 2 isn't working as expected. There should always be an empty block after a timeout if there are not transactions, but I don't see one here

I don’t ask for crypto. M◉⃤|<𓊖༒𓊖 Takemiya 武宮誠 (Sora.org & SORAMITSU), [2025/02/14 3:00]
It's needed because sumeragi doesn't have a secondary commit phase because we are a blockchain protocol and it is expected there will always be another block. If there are no transactions after a timeout period from the previous block with transactions, then an empty block should be created to commit and finalize the previous block. This works because to commit a new block you need 2f+1 signatures, so it proves a majority of the network has the previous block and allows for transaction finality.

@s8sato s8sato added Bug Something isn't working Consensus This issue is related to the Sumeragi consensus labels Feb 14, 2025
@dima74 dima74 self-assigned this Feb 14, 2025
@dima74 dima74 linked a pull request Feb 18, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Consensus This issue is related to the Sumeragi consensus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants