feat!: Allow empty blocks #5320
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Murzin <[email protected]>
Signed-off-by: Dmitry Murzin <[email protected]>
Signed-off-by: Dmitry Murzin <[email protected]>
dima74
requested review from
s8sato,
mversic,
outoftardis,
0x009922 and
DCNick3
as code owners
s8sato
reviewed
Feb 20, 2025
Comment on lines
-887
to
+886
| if tx_cache_full || tx_cache_non_empty && (view_change_in_progress || deadline_reached) { | ||
| if tx_cache_full || view_change_in_progress || deadline_reached { |
There was a problem hiding this comment.
I'm not sure if continuously creating blocks, regardless of whether the previous block is empty, meets the requirement
There was a problem hiding this comment.
I think the requirement was just to finalize the last block and avoid soft fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #5317
Solution
Allow empty blocks (without transactions)
Migration Guide
Note that if you have pre-commit trigger, it will now be run also for empty blocks
TODO:
Checklist
CONTRIBUTING.md.