Refactor/result bind #101
Merged
Refactor/result bind #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-egorov
approved these changes
Jun 5, 2019
| constexpr bool isError = std::is_base_of<ErrorBase, T>::value; | ||
|
|
||
| /** | ||
| * A struct that provides the result type conversion for bind operator. |
There was a problem hiding this comment.
?
Suggested change
| * A struct that provides the result type conversion for bind operator. | |
| * A struct that provides the result of type conversion for bind operator. |
| * function outcome and former Result error type, and a method to convert | ||
| * transformation function outcome to this type. | ||
| */ | ||
| template <typename Transformed, typename ErrorType, typename = void> |
There was a problem hiding this comment.
it is needed for partial specialisation (please see below)
It is a standalone part of changes in #84, which was taken into a separate PR (this one) to alleviate that change that became rather big. |
muratovv
approved these changes
Jun 7, 2019
Signed-off-by: Mikhail Boldyrev <[email protected]>
Signed-off-by: Mikhail Boldyrev <[email protected]>
MBoldyrev
force-pushed
the
refactor/result-bind
branch
from
fa3bf42 to
4429ea9
Compare
nvzhu
pushed a commit
to soramitsu/soramitsu-iroha
that referenced
this pull request
Jan 9, 2024
…egration-tests Send batch transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Now the bound transformation function may return one of:
Result,Valueor any other unwrapped value that is treated like aValue. Also, a rvalue-reference binding specialization is added. Two functions to convert aResult'sErrororValuetoboost::optionalare added.Benefits
Hopefully allows to write a simpler code.
Possible Drawbacks
More code to maintain.
Usage Examples or Tests [optional]
Alternate Designs [optional]