-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[documentation] #2181: Review README #2190
Merged
SamHSmith
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
outoftardis:doc-readme-review
May 11, 2022
Merged
[documentation] #2181: Review README #2190
SamHSmith
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
outoftardis:doc-readme-review
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appetrosyan
reviewed
May 11, 2022
appetrosyan
reviewed
May 11, 2022
appetrosyan
reviewed
May 11, 2022
appetrosyan
reviewed
May 11, 2022
appetrosyan
reviewed
May 11, 2022
appetrosyan
reviewed
May 11, 2022
appetrosyan
reviewed
May 11, 2022
appetrosyan
reviewed
May 11, 2022
appetrosyan
reviewed
May 11, 2022
3a4e536
to
3b2bba4
Compare
outoftardis
commented
May 11, 2022
outoftardis
commented
May 11, 2022
appetrosyan
reviewed
May 11, 2022
appetrosyan
reviewed
May 11, 2022
appetrosyan
reviewed
May 11, 2022
Signed-off-by: Ekaterina Mekhnetsova <[email protected]>
3b2bba4
to
a0af3e1
Compare
appetrosyan
approved these changes
May 11, 2022
SamHSmith
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ekaterina Mekhnetsova [email protected]
Description of the Change
Review README. View file: https://github.com/outoftardis/iroha/tree/doc-readme-review#hyperledger-iroha
Issue
Addresses #2181