-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement iroha-lib separate module for Hyperledger Iroha 1 #2660
Conversation
I'd recommend looking at the coverage first. Iroha 1 in general has a very different approach to testing, so IMO unit tests in this case are unnecessary.
I fully agree. However, I'd be pragmatic, it seems like a good task for another intern.
Yes, but not now. Ursa is going to undergo a significant change, so I'd wait until at least Christmas before starting this work.
C-abi library sounds good, but it's going to take a lot of extra work and meticulous code review. Dynamic linkage with a C++-based binary is non-trivial.
Agreed. I'll help with the review. |
This is a source code for HL Iroha C++ library. | ||
|
||
Currently, latest HL Iroha 1.5 release (`hyperledger/iroha:latest` Docker image) is supported. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This readme tells the user next to nothing about what the library is supposed to do. If it's an example, you should say so. If it is a library that does stuff, similarly it should explain what it does, and why it's included in the source code of Iroha.
68e0747
to
16bb09a
Compare
16bb09a
to
acfdeb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks almost for good me. Only some examples are missing and documentation (especially how to use the library), but they can be added in another PR.
That is why this PR can be merged as it is.
Good job!
Signed-off-by: Andrzej <[email protected]>
This is a source code for HL Iroha C++ library.
Currently, the latest HL Iroha 1.5 release (hyperledger/iroha:latest Docker image) is supported.
Possible actions: