Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/gRPC drop stream bugfix #2749

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Fix/gRPC drop stream bugfix #2749

merged 4 commits into from
Oct 12, 2022

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Sep 15, 2022

Description of the Change

  1. Remove timeout of gRPC deadline for stream.
  2. Fixed logout crash.
  3. Add reestablish YAC stream if previous send was failed

@iceseer iceseer self-assigned this Sep 15, 2022
@iceseer iceseer added the 1.5 label Sep 15, 2022
@iceseer iceseer requested a review from Mingela September 15, 2022 07:29
Mingela
Mingela previously approved these changes Sep 15, 2022
View reviewed changes
@iceseer iceseer force-pushed the fix/gRPC_drop_stream_bugfix branch 2 times, most recently from 962351a to 84e2425 Compare September 15, 2022 19:21
@iceseer @appetrosyan
remove streaming grpc timeout on status send
b821b3e 
Signed-off-by: iceseer <[email protected]>
Signed-off-by: Alexander Lednev <[email protected]>

IntegrationTest: log message fixup

Signed-off-by: iceseer <[email protected]>
Signed-off-by: Alexander Lednev <[email protected]>
Signed-off-by: iceseer <[email protected]>
@iceseer @appetrosyan
remove yac stream
37ad236 
Signed-off-by: iceseer <[email protected]>
@iceseer @appetrosyan
proposal pack
f2db3af 
Signed-off-by: iceseer <[email protected]>
@iceseer @appetrosyan
log
f347171 
Signed-off-by: iceseer <[email protected]>
@appetrosyan appetrosyan force-pushed the fix/gRPC_drop_stream_bugfix branch from 84e2425 to f347171 Compare September 29, 2022 06:28
@appetrosyan appetrosyan enabled auto-merge (squash) September 29, 2022 06:29
@appetrosyan appetrosyan disabled auto-merge October 2, 2022 11:55
@appetrosyan appetrosyan merged commit fdb8e79 into develop Oct 12, 2022
@appetrosyan appetrosyan deleted the fix/gRPC_drop_stream_bugfix branch October 12, 2022 10:00
@6r1d 6r1d mentioned this pull request Oct 18, 2022
Open
@baziorek baziorek mentioned this pull request Oct 18, 2022
Closed
@baziorek baziorek mentioned this pull request Feb 13, 2023
Merged
6r1d pushed a commit to 6r1d/iroha that referenced this pull request Aug 28, 2023
@iceseer @6r1d
Fix/gRPC drop stream bugfix (hyperledger-iroha#2749)
08d155c 
Signed-off-by: iceseer <[email protected]>
@nxsaken nxsaken added the iroha1 The legacy version of Iroha. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appetrosyan appetrosyan appetrosyan approved these changes

@Mingela Mingela Mingela left review comments

Assignees

@iceseer iceseer

Labels
1.5 iroha1 The legacy version of Iroha.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iceseer @appetrosyan @Mingela @nxsaken