Repaired building iroha according to instruction: Added patch file to repair building of benchmark library: std::numeric_limits requires <limits> header #2906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This is really similar to #2902, but there is problem with another dependency: benchmark library.
When building according to the instruction, which is with command:
Suddenly building is stopping with message:
In the log file is problem:
So to fix its it is enough to add to the file:
benchmark_register.h
extra line:So I've corrected this according to instruction: https://stackoverflow.com/questions/72588408/vcpkg-how-to-edit-package-file-when-compilation-fails-when-installing-package
I'm using Ubuntu 22.04, with version of g++: g++ (Ubuntu 11.2.0-19ubuntu1) 11.2.0.
Issue
Benefits
Automatic build of HL Iroha
Possible Drawbacks
Chosen way of fix can be not best possible (maybe upgrading the library would be better, but more dangerous).
Usage Examples or Tests [optional]
After the fix the command:
is passing to build
benchmark
without any hacks described here.Alternate Designs [optional]