Added more descriptive Readme file. #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baziorek
requested changes
Nov 5, 2022
There was a problem hiding this comment.
Few small comments.
BTW. Could You please add:
#incude <optional>
to files:
- iroha/iroha-lib/model/generators/CommandGenerator.hpp
- iroha/iroha-lib/model/generators/QueryGenerator.hpp
because when I was trying to build the library in my compiler it was not compiling (probably I have never g++ than You).
outoftardis
reviewed
Nov 7, 2022
outoftardis
reviewed
Nov 8, 2022
Signed-off-by: Andrzej <[email protected]>
andprogrammer
force-pushed
the
develop
branch
from
773b602 to
fa32e2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe how Hyperledger Iroha C++ library works. Provide examples. Show how to install and use the current version of the library.
Show how to run examples with transactions, batch and commands.
Benefits:
End user will know what the library is responsible for and how to use it properly.