Introduce an optional title parameter to the AddAssetQuantity and SubtractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dominious1 Please add some description. I know that it is connected with internship project, but others also should know. And also provide link to client library. |
baziorek
reviewed
Oct 18, 2023
baziorek
requested changes
Nov 1, 2023
There was a problem hiding this comment.
- remember about changing documentation
- remember about adding changes to iroha-lib (file:
iroha/iroha-lib/model/Tx.{h,c}pp), if You have problems with this ask @andprogrammer
Signed-off-by: dominious1 <[email protected]>
Signed-off-by: dominious1 <[email protected]>
Signed-off-by: dominious1 <[email protected]>
|
@dominious1 Good news! I was able (hopefully) to fix dependencies with golang: #4173 |
Signed-off-by: dominious1 <[email protected]>
|
To sum up changes:
|
Mingela
approved these changes
Jan 12, 2024
|
It was also checked by @iceseer |
Sorry, I was wrong, it was checked by @iceseer not @lebdron . Sorry, it is my faoult that I not always connect nicks with people. Sorry for wrong information from me. Thanks @6r1d for correcting me:) |
baziorek
added a commit
to dominious1/iroha
that referenced
this pull request
Jan 26, 2024
…tractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. (hyperledger-iroha#4003) * Implement addition of new parameters to Iroha Core for enhanced message communication, with corresponding handling capabilities in Iroha CLI. * Improve GTests in reference to param title * Enhance test coverage in the JsonCommandTest class by addressing serialization and deserialization scenarios for various command types. This commit ensures comprehensive testing, including edge cases and unknown command types, to guarantee the robustness of the JsonCommandFactory's functionality. * Enhance test cases related to the SubtractAccountAsset functionality to improve reliability, readability, and maintainability. This commit refactors and strengthens the existing test suite, addressing scenarios such as permission checks, domain permission validity, asset presence, precision validation, and asset quantity sufficiency. These improvements contribute to a more robust testing environment for the SubtractAccountAsset functionality. Signed-off-by: dominious1 <[email protected]> --------- Signed-off-by: dominious1 <[email protected]> Signed-off-by: dominious1 <[email protected]> Co-authored-by: G. Bazior <[email protected]>
baziorek
added a commit
to dominious1/iroha
that referenced
this pull request
Jan 26, 2024
…tractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. (hyperledger-iroha#4003) * Implement addition of new parameters to Iroha Core for enhanced message communication, with corresponding handling capabilities in Iroha CLI. * Improve GTests in reference to param title * Enhance test coverage in the JsonCommandTest class by addressing serialization and deserialization scenarios for various command types. This commit ensures comprehensive testing, including edge cases and unknown command types, to guarantee the robustness of the JsonCommandFactory's functionality. * Enhance test cases related to the SubtractAccountAsset functionality to improve reliability, readability, and maintainability. This commit refactors and strengthens the existing test suite, addressing scenarios such as permission checks, domain permission validity, asset presence, precision validation, and asset quantity sufficiency. These improvements contribute to a more robust testing environment for the SubtractAccountAsset functionality. Signed-off-by: dominious1 <[email protected]> --------- Signed-off-by: dominious1 <[email protected]> Signed-off-by: dominious1 <[email protected]> Co-authored-by: G. Bazior <[email protected]>
dominious1
added a commit
to dominious1/iroha
that referenced
this pull request
Feb 1, 2024
…tractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. (hyperledger-iroha#4003) * Implement addition of new parameters to Iroha Core for enhanced message communication, with corresponding handling capabilities in Iroha CLI. * Improve GTests in reference to param title * Enhance test coverage in the JsonCommandTest class by addressing serialization and deserialization scenarios for various command types. This commit ensures comprehensive testing, including edge cases and unknown command types, to guarantee the robustness of the JsonCommandFactory's functionality. * Enhance test cases related to the SubtractAccountAsset functionality to improve reliability, readability, and maintainability. This commit refactors and strengthens the existing test suite, addressing scenarios such as permission checks, domain permission validity, asset presence, precision validation, and asset quantity sufficiency. These improvements contribute to a more robust testing environment for the SubtractAccountAsset functionality. Signed-off-by: dominious1 <[email protected]> --------- Signed-off-by: dominious1 <[email protected]> Signed-off-by: dominious1 <[email protected]> Co-authored-by: G. Bazior <[email protected]> Signed-off-by: dominious1 <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance functionality in the C++ Iroha base core code by introducing an optional argument, "title," to the AddAssetQuantity and SubtractAssetQuantity commands within the commands.proto bufs. Ensure seamless integration and functionality of this optional parameter, and optimize associated Gtests to accommodate these modifications. Additionally, enhance the Python client, contained in a separate repository, to effectively handle these changes. This refinement contributes to a more robust and adaptable system, aligning with the evolving requirements of the codebase.
Link to Python client library which use protobuf GRPC shared code base:
https://github.com/hyperledger/iroha-python/
This is part of internship project:
https://wiki.hyperledger.org/display/INTERN/Iroha+1%3A+extend+queries+with+optional+arguments
Link to PR in iroha-python compatible with those changes:
hyperledger-iroha/iroha-python#157
PR which updates documentation:
#4032