-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: Optimize executor #4013
Merged
Arjentix
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
Arjentix:optimize_executor
Oct 31, 2023
Merged
[refactor]: Optimize executor #4013
Arjentix
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
Arjentix:optimize_executor
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6705703228
💛 - Coveralls |
mversic
reviewed
Oct 24, 2023
Erigara
previously approved these changes
Oct 27, 2023
b1cd7ac
to
ad5e7ea
Compare
mversic
previously approved these changes
Oct 31, 2023
Signed-off-by: Daniil Polyakov <[email protected]>
ad5e7ea
to
1f91725
Compare
mversic
approved these changes
Oct 31, 2023
Erigara
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Optimization
Something isn't working as well as it should
Refactor
Improvement to overall code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally this work was about #3991. But after implementing reference counting for
ConstString
I got these results:I measured memory using the next command:
gtime -f 'Time passed: %E\nMax memory used: %M kbytes' ../../target/release/examples/apply_blocks
Where
gtime
is atime
utility by GNU, which can be installed on mac usingbrew install gnu-time
So it defenelty doesn't worth it.
You can do your own research. Take a look at my branch: https://github.com/arjentix/iroha/tree/arc_name
apply_blocks
benchmarkapply_blocks
even more heavy with long idsiroha2-dev
, the issue was a very long transaction deallocation inside wasm executor, so fixed that withcore::mem::forget()
Benefits
Checklist
CONTRIBUTING.md