Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #3657: Split view changes from normal messages #4115

Merged

Conversation

SamHSmith
Copy link
Contributor

@SamHSmith SamHSmith commented Dec 5, 2023

Description

Linked issue

Closes #3657

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@SamHSmith SamHSmith self-assigned this Dec 5, 2023
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 5, 2023
@coveralls
Copy link

coveralls commented Dec 5, 2023

Pull Request Test Coverage Report for Build 7188015096

  • 0 of 112 (0.0%) changed or added relevant lines in 4 files are covered.
  • 7071 unchanged lines in 130 files lost coverage.
  • Overall coverage decreased (-3.2%) to 56.275%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/block_sync.rs 0 2 0.0%
core/src/sumeragi/message.rs 0 7 0.0%
core/src/sumeragi/mod.rs 0 20 0.0%
core/src/sumeragi/main_loop.rs 0 83 0.0%
Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
config/src/logger.rs 3 92.68%
data_model/derive/src/has_origin.rs 3 95.16%
Totals Coverage Status
Change from base Build 5423219773: -3.2%
Covered Lines: 23056
Relevant Lines: 40970

💛 - Coveralls

Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version of rustfmt do you use? Because i noticed some formatting changes not relevant to this PR.

@Arjentix Arjentix self-assigned this Dec 5, 2023
@SamHSmith SamHSmith force-pushed the split_control_messages branch 3 times, most recently from 58d143a to e07fe56 Compare December 9, 2023 17:39
@SamHSmith SamHSmith marked this pull request as ready for review December 9, 2023 17:52
@mversic
Copy link
Contributor

mversic commented Dec 11, 2023

please change git commit message to [refactor]

@SamHSmith SamHSmith force-pushed the split_control_messages branch from e07fe56 to b38b194 Compare December 12, 2023 22:25
@mversic mversic changed the title [fix] #3657: Split view changes from normal messages [refactor] #3657: Split view changes from normal messages Dec 14, 2023
@mversic mversic force-pushed the split_control_messages branch from b38b194 to 1523d89 Compare December 14, 2023 07:05
@SamHSmith SamHSmith force-pushed the split_control_messages branch 2 times, most recently from c1e4b97 to 29507d6 Compare December 20, 2023 01:51
@SamHSmith SamHSmith force-pushed the split_control_messages branch from 29507d6 to a674235 Compare January 11, 2024 19:44
@SamHSmith SamHSmith force-pushed the split_control_messages branch from a674235 to 2781734 Compare January 11, 2024 20:39
@SamHSmith SamHSmith force-pushed the split_control_messages branch 3 times, most recently from 67402e2 to 26e8f77 Compare January 17, 2024 23:41
@mversic mversic force-pushed the split_control_messages branch from 26e8f77 to 9e6f38b Compare January 22, 2024 09:01
@mversic mversic requested review from Arjentix and mversic January 22, 2024 09:02
@mversic mversic merged commit ba7577e into hyperledger-iroha:iroha2-dev Jan 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants