-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] #3657: Split view changes from normal messages #4115
Merged
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
SamHSmith:split_control_messages
Jan 22, 2024
Merged
[refactor] #3657: Split view changes from normal messages #4115
mversic
merged 1 commit into
hyperledger-iroha:iroha2-dev
from
SamHSmith:split_control_messages
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7188015096
💛 - Coveralls |
Erigara
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What version of rustfmt
do you use? Because i noticed some formatting changes not relevant to this PR.
Arjentix
reviewed
Dec 5, 2023
58d143a
to
e07fe56
Compare
Erigara
reviewed
Dec 11, 2023
please change git commit message to |
mversic
reviewed
Dec 11, 2023
e07fe56
to
b38b194
Compare
b38b194
to
1523d89
Compare
mversic
reviewed
Dec 14, 2023
mversic
reviewed
Dec 14, 2023
c1e4b97
to
29507d6
Compare
29507d6
to
a674235
Compare
a674235
to
2781734
Compare
mversic
reviewed
Jan 12, 2024
mversic
reviewed
Jan 12, 2024
67402e2
to
26e8f77
Compare
Erigara
approved these changes
Jan 22, 2024
Signed-off-by: Sam H. Smith <[email protected]>
26e8f77
to
9e6f38b
Compare
mversic
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue
Closes #3657
Benefits
Checklist
CONTRIBUTING.md