-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #3453: Implement Store set, remove, get operations in Client CLI #4163
[feature] #3453: Implement Store set, remove, get operations in Client CLI #4163
Conversation
…KS env variable with true Signed-off-by: Asem-Abdelhady <[email protected]>
…ng PORFILE variable to be test Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
…atic CIs Signed-off-by: Asem-Abdelhady <[email protected]>
… checking from dev CI Signed-off-by: Asem-Abdelhady <[email protected]>
…from nix Signed-off-by: Asem-Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
a626e62
to
35fa7b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, lgtm
@Asem-Abdelhady some python tests should be added to cover new functionality (maybe as separate PR) |
1bab173
to
48e3f4a
Compare
Signed-off-by: Asem Abdelhady <[email protected]> Signed-off-by: Asem-Abdelhady <[email protected]>
48e3f4a
to
dbb52eb
Compare
ea5c6a5
to
5bf5528
Compare
6df7d12
to
fc7cdda
Compare
309a703
to
e826970
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes again primarily because of complete removal of #[arg(long)]
for asset_id
argument, making it a positional argument. It is inconsistent with the rest of the CLI.
Signed-off-by: Asem-Abdelhady <[email protected]>
e826970
to
da709e0
Compare
15bc2e7
into
hyperledger-iroha:iroha2-dev
…erations in Client CLI (hyperledger-iroha#4163) * [add] store set, remove and get operations feature in client cli Signed-off-by: Asem-Abdelhady <[email protected]> Signed-off-by: Asem-Abdelhady <[email protected]>
…erations in Client CLI (hyperledger-iroha#4163) * [add] store set, remove and get operations feature in client cli Signed-off-by: Asem-Abdelhady <[email protected]>
Description
I added extra subcommands to asset which are set-store, get-store, remove-store, update-store
Use Casees
Linked issue
Closes #3453
Checklist
CONTRIBUTING.md