Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #3453: Implement Store set, remove, get operations in Client CLI #4163

Merged
merged 18 commits into from
Jan 11, 2024

Conversation

Asem-Abdelhady
Copy link
Contributor

@Asem-Abdelhady Asem-Abdelhady commented Dec 21, 2023

Description

I added extra subcommands to asset which are set-store, get-store, remove-store, update-store

Use Casees

./iroha_client_cliasset set-key-value --asset-id="tea##mad_hatter@looking_glass" --key="K5" --value='{ "Vec": [{"String": "a"}, {"String": "b"}] }'
---
./iroha_client_cli asset get-key-value --asset-id="tea##mad_hatter@looking_glass" --key="K5"   
---
./iroha_client_cli asset remove-key-value --asset-id="tea##mad_hatter@looking_glass" --key="K5"   

Linked issue

Closes #3453

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

…KS env variable with true

Signed-off-by: Asem-Abdelhady <[email protected]>
…ng PORFILE variable to be test

Signed-off-by: Asem-Abdelhady <[email protected]>
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 21, 2023
@Asem-Abdelhady Asem-Abdelhady changed the title [add] #3453: Add store CRUD operations feature in client cli [add] #3453: Add store CRUD operations feature in client CLI Dec 21, 2023
@Asem-Abdelhady Asem-Abdelhady changed the title [add] #3453: Add store CRUD operations feature in client CLI [feature] #3453: Implement Store CRUD Operations in Client CLI Dec 21, 2023
Erigara
Erigara previously approved these changes Dec 25, 2023
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, lgtm

@Erigara
Copy link
Contributor

Erigara commented Dec 25, 2023

@Asem-Abdelhady some python tests should be added to cover new functionality (maybe as separate PR)

Signed-off-by: Asem Abdelhady <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
@Asem-Abdelhady Asem-Abdelhady force-pushed the iroha2-dev branch 2 times, most recently from ea5c6a5 to 5bf5528 Compare January 1, 2024 12:01
@Asem-Abdelhady Asem-Abdelhady force-pushed the iroha2-dev branch 4 times, most recently from 6df7d12 to fc7cdda Compare January 9, 2024 09:53
@Asem-Abdelhady Asem-Abdelhady force-pushed the iroha2-dev branch 2 times, most recently from 309a703 to e826970 Compare January 9, 2024 14:33
Copy link
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes again primarily because of complete removal of #[arg(long)] for asset_id argument, making it a positional argument. It is inconsistent with the rest of the CLI.

@Asem-Abdelhady Asem-Abdelhady merged commit 15bc2e7 into hyperledger-iroha:iroha2-dev Jan 11, 2024
10 checks passed
Asem-Abdelhady added a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 22, 2024
…erations in Client CLI (hyperledger-iroha#4163)

* [add] store set, remove and get operations feature in client cli

Signed-off-by: Asem-Abdelhady <[email protected]>

Signed-off-by: Asem-Abdelhady <[email protected]>
Asem-Abdelhady added a commit to Asem-Abdelhady/iroha that referenced this pull request Feb 9, 2024
…erations in Client CLI (hyperledger-iroha#4163)

* [add] store set, remove and get operations feature in client cli

Signed-off-by: Asem-Abdelhady <[email protected]>
@0x009922 0x009922 mentioned this pull request Mar 7, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants