Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] #4126: Add chain_id to prevent replay attacks #4185

Merged
merged 2 commits into from
Jan 15, 2024
Merged

[feature] #4126: Add chain_id to prevent replay attacks #4185

merged 2 commits into from
Jan 15, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Jan 9, 2024

Description

Linked issue

Closes #4126

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jan 9, 2024
@mversic mversic force-pushed the prevent_cross_chain_attack branch 2 times, most recently from 637beed to d6be187 Compare January 9, 2024 07:56
@mversic mversic force-pushed the prevent_cross_chain_attack branch 6 times, most recently from 5cf8df7 to 9beb6c3 Compare January 9, 2024 11:24
Erigara
Erigara reviewed Jan 9, 2024
View reviewed changes
@Erigara
Copy link
Contributor

Erigara commented Jan 9, 2024

Let's in future separate versions bump in different commit

@mversic mversic force-pushed the prevent_cross_chain_attack branch 7 times, most recently from 6d972bb to 04a5362 Compare January 9, 2024 14:27
@mversic mversic force-pushed the prevent_cross_chain_attack branch from d01ecdb to fbdacad Compare January 11, 2024 10:51
Erigara
Erigara previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few optional comments

DCNick3
DCNick3 previously approved these changes Jan 11, 2024
View reviewed changes
@mversic mversic dismissed stale reviews from DCNick3 and Erigara via 65c40e5 January 11, 2024 12:37
@mversic mversic force-pushed the prevent_cross_chain_attack branch from fbdacad to 65c40e5 Compare January 11, 2024 12:37
Erigara
Erigara previously approved these changes Jan 11, 2024
View reviewed changes
@Erigara Erigara dismissed their stale review January 11, 2024 12:44

Failing tests

@mversic mversic force-pushed the prevent_cross_chain_attack branch 2 times, most recently from ab90379 to 77dcdbf Compare January 12, 2024 05:55
DCNick3
DCNick3 previously approved these changes Jan 12, 2024
View reviewed changes
@mversic mversic force-pushed the prevent_cross_chain_attack branch 3 times, most recently from d705815 to cd4f2f5 Compare January 12, 2024 09:47
@Erigara Erigara mentioned this pull request Jan 12, 2024
Open
@mversic mversic force-pushed the prevent_cross_chain_attack branch from cd4f2f5 to 138f2e1 Compare January 15, 2024 07:23
@mversic mversic force-pushed the prevent_cross_chain_attack branch from 138f2e1 to e351235 Compare January 15, 2024 10:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7527630250

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 56.99%
Totals Coverage Status
Change from base Build 7285255818: 0.9%
Covered Lines: 22604
Relevant Lines: 39663
💛 - Coveralls

@mversic mversic merged commit ce4538f into hyperledger-iroha:iroha2-dev Jan 15, 2024
12 checks passed
@mversic mversic deleted the prevent_cross_chain_attack branch January 15, 2024 10:56
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 18, 2024
@mversic @Asem-Abdelhady
[feature] hyperledger-iroha#4126: Add chain_id to prevent replay atta…
f5f4af5 
…cks (hyperledger-iroha#4185)

* [feature] hyperledger-iroha#4126: Add chain_id to prevent replay attacks

Signed-off-by: Marin Veršić <[email protected]>

* [feature]: add implementation for Box<str> FFI conversion

Signed-off-by: Marin Veršić <[email protected]>
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 18, 2024
@mversic @Asem-Abdelhady
[feature] hyperledger-iroha#4126: Add chain_id to prevent replay atta…
a50e4a0 
…cks (hyperledger-iroha#4185)

* [feature] hyperledger-iroha#4126: Add chain_id to prevent replay attacks

Signed-off-by: Marin Veršić <[email protected]>

* [feature]: add implementation for Box<str> FFI conversion

Signed-off-by: Marin Veršić <[email protected]>
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 18, 2024
@mversic @Asem-Abdelhady
[feature] hyperledger-iroha#4126: Add chain_id to prevent replay atta…
8ef8626 
…cks (hyperledger-iroha#4185)

* [feature] hyperledger-iroha#4126: Add chain_id to prevent replay attacks

Signed-off-by: Marin Veršić <[email protected]>

* [feature]: add implementation for Box<str> FFI conversion

Signed-off-by: Marin Veršić <[email protected]>
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 22, 2024
@mversic @Asem-Abdelhady
[feature] hyperledger-iroha#4126: Add chain_id to prevent replay atta…
b55b484 
…cks (hyperledger-iroha#4185)

* [feature] hyperledger-iroha#4126: Add chain_id to prevent replay attacks

Signed-off-by: Marin Veršić <[email protected]>

* [feature]: add implementation for Box<str> FFI conversion

Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Asem-Abdelhady <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DCNick3 DCNick3 DCNick3 approved these changes

@Erigara Erigara Erigara approved these changes

@s8sato s8sato Awaiting requested review from s8sato

@Arjentix Arjentix Awaiting requested review from Arjentix

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@QuentinI QuentinI Awaiting requested review from QuentinI

@outoftardis outoftardis Awaiting requested review from outoftardis

@ilchu ilchu Awaiting requested review from ilchu

@pesterev pesterev Awaiting requested review from pesterev

@0x009922 0x009922 Awaiting requested review from 0x009922

Assignees

@DCNick3 DCNick3

@Erigara Erigara

@mversic mversic

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mversic @Erigara @coveralls @DCNick3