Fix issue with uncaught exception in logger #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin Munichev <[email protected]>
igor-egorov
approved these changes
Apr 30, 2019
Signed-off-by: Konstantin Munichev <[email protected]>
Signed-off-by: Konstantin Munichev <[email protected]>
lebdron
approved these changes
May 2, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Pull request fixes irohad crash on receiving SetAccountDetail transaction with value field set to
"{}".Benefits
No crash^^
Possible Drawbacks
Command doesn't pass stateful validation with message
command 'SetAccountDetail' with index '0' did not pass verification with code '1'. Code 1 means "internal error" which isn't a user friendly message. I suggest either to create additional stateless validation rule or improve error message (or maybe even so some escaping for Postgres).