Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #4332: Remove corresponding triggers on Unregister<Domain> #4461

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

mirna-versic
Copy link
Contributor

Description of the Change

Triggers that are living in a domain are now deleted when that domain is deleted.

Closes #4332

Benefits

Fixes the bug.

Possible Drawbacks

None

Usage Examples or Tests [optional]

Alternate Designs [optional]

@github-actions github-actions bot added the Bug Something isn't working label Apr 17, 2024
@mversic mversic assigned mversic and mirna-versic and unassigned mversic Apr 17, 2024
@mversic mversic added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Apr 17, 2024
@Erigara
Copy link
Contributor

Erigara commented Apr 17, 2024

Please format commit like:

[fix] #4332: Remove corresponding triggers on `Unregister<Domain>`

Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nxsaken nxsaken merged commit 829fceb into hyperledger-iroha:main Apr 17, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove triggers on Unregister<Domain>
4 participants