fix: Remove nested option on TransactionEventFilter::block_height
#4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3,
VAmuzing,
Asem-Abdelhady and
dima74
as code owners
mversic
force-pushed
the
remove_nested_option
branch
2 times, most recently
from
ca21d95 to
b114ae1
Compare
mversic
changed the title
mversic
changed the title
TransactionEventFilter::block_height
mversic
changed the title
TransactionEventFilter::block_heightTransactionEventFilter::block_height
mversic
force-pushed
the
remove_nested_option
branch
3 times, most recently
from
c258622 to
a3db87d
Compare
nxsaken
approved these changes
May 2, 2024
Erigara
reviewed
May 2, 2024
Erigara
approved these changes
May 2, 2024
Closed
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
Signed-off-by: Marin Veršić <[email protected]>
mversic
force-pushed
the
remove_nested_option
branch
from
a3db87d to
5d1f0f0
Compare
mversic
merged commit dba0e19
into
hyperledger-iroha:2.0.0-pre-rc.21
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue
Closes #{issue_number}
Benefits
Checklist
CONTRIBUTING.md