fix(crypto): do not panic if the passed Ed25519Sha512 public key is of invalid length #4650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCNick3
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922,
VAmuzing and
dima74
as code owners
VAmuzing
reviewed
May 27, 2024
VAmuzing
previously approved these changes
May 27, 2024
VAmuzing
approved these changes
May 27, 2024
mversic
approved these changes
May 28, 2024
…f invalid length Signed-off-by: Nikita Strygin <[email protected]>
…ey is of invalid length Signed-off-by: Nikita Strygin <[email protected]>
mversic
force-pushed
the
fix-iroha_crypto-pk-parse-panic
branch
from
8084904 to
27ec95a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the conversion of unsized slice to array reference to be infallible and form a better error message.
This prevents a panic during
parity_scale_cli's type probingLinked issue
Closes #4649
Checklist