chore(debug): improve deserialization error message #4659

mversic · 2024-05-28T11:23:38Z

Description

Closes #{issue_number}

I've read CONTRIBUTING.md
I've used the standard signed-off commit format (or will squash just before merging)
All applicable CI checks pass (or I promised to make them pass later)
(optional) I've written unit tests for the code changes
I replied to all comments after code review, marking all implemented changes with thumbs up

data_model/src/permission.rs

Signed-off-by: Marin Veršić <[email protected]>

mversic requested review from s8sato, SamHSmith, outoftardis, Erigara, 0x009922, DCNick3, VAmuzing and dima74 as code owners May 28, 2024 11:23

mversic force-pushed the debugging_improv_main branch 3 times, most recently from 49eebfe to 8ad120c Compare May 28, 2024 12:27

VAmuzing reviewed May 28, 2024

View reviewed changes

data_model/src/permission.rs Show resolved Hide resolved

mversic force-pushed the debugging_improv_main branch 2 times, most recently from 9dae588 to 304ecdd Compare May 29, 2024 06:42

mversic requested a review from VAmuzing May 29, 2024 06:44

nxsaken previously approved these changes May 29, 2024

View reviewed changes

0x009922 previously approved these changes May 29, 2024

View reviewed changes

chore(debug): improve deserialization error message

e37e681

Signed-off-by: Marin Veršić <[email protected]>

mversic dismissed stale reviews from 0x009922 and nxsaken via e37e681 May 29, 2024 06:56

mversic force-pushed the debugging_improv_main branch from 304ecdd to e37e681 Compare May 29, 2024 06:56

mversic enabled auto-merge (squash) May 29, 2024 06:57

nxsaken approved these changes May 29, 2024

View reviewed changes

0x009922 approved these changes May 29, 2024

View reviewed changes

mversic merged commit f0edcb7 into hyperledger-iroha:main May 29, 2024
10 of 11 checks passed

mversic deleted the debugging_improv_main branch May 29, 2024 07:04