Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Supply SignedBlock instead of SignedTransaction to peer #4739

Merged
merged 8 commits into from
Jun 20, 2024
Merged

refactor!: Supply SignedBlock instead of SignedTransaction to peer #4739

merged 8 commits into from
Jun 20, 2024

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Jun 18, 2024 •
edited
Loading

Description

This is first part of #4696:

  • Added topology field to genesis.json
  • Changed kagami genesis sign to generate SignedBlock
  • Adapted iroha_swarm and test_env.py to those changes

Planned changes for next PRs:

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@dima74 dima74 self-assigned this Jun 18, 2024
mversic
mversic requested changes Jun 18, 2024
View reviewed changes
@Erigara Erigara self-assigned this Jun 18, 2024
@mversic mversic self-assigned this Jun 18, 2024
@dima74 dima74 requested a review from mversic June 19, 2024 09:14
mversic
mversic previously approved these changes Jun 19, 2024
View reviewed changes
mversic
mversic reviewed Jun 19, 2024
View reviewed changes
@mversic
Copy link
Contributor

mversic commented Jun 19, 2024 •
edited
Loading

A thing that I have noticed. We don't validate genesis instructions at all anymore because there is no initial executor. This is a bug, only the 1st instruction (which is upgrade) should not be validated, all others should. Opened #4743

@mversic mversic mentioned this pull request Jun 19, 2024
Closed
mversic
mversic previously approved these changes Jun 19, 2024
View reviewed changes
@mversic mversic force-pushed the diralik/all-peers-submit-genesis branch from 3bb780c to d15e9a8 Compare June 19, 2024 11:20
Erigara
Erigara reviewed Jun 19, 2024
View reviewed changes
dima74 added 8 commits June 20, 2024 13:00
@dima74
refactor!: Supply SignedBlock instead of SignedTransaction to peer
eae3629 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74
fix: Use correct topology in docker compose
f27b1ab 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74
Check that first instruction is Upgrade
ba15c3a 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74
Don't use transparent_api in iroha_genesis
b0d8d48 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74
Rename to SignedBlock::genesis
16f6dbd 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74
scripts/test_env.py: set topology in genesis.json
509d95d 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74
docker compose: use jq to set topology in genesis.json
641bb35 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74
Sign genesis block with genesis private key
6d9e2ff 
Signed-off-by: Dmitry Murzin <[email protected]>
@dima74 dima74 force-pushed the diralik/all-peers-submit-genesis branch from d15e9a8 to 6d9e2ff Compare June 20, 2024 11:52
@dima74 dima74 requested review from Erigara and mversic June 20, 2024 11:58
@dima74 dima74 merged commit 0424c39 into hyperledger-iroha:main Jun 20, 2024
10 of 11 checks passed
@dima74 dima74 deleted the diralik/all-peers-submit-genesis branch June 20, 2024 12:45
This was referenced Jun 20, 2024
Merged
Merged
@s8sato s8sato mentioned this pull request Oct 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erigara Erigara Erigara approved these changes

@mversic mversic mversic approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

Assignees

@dima74 dima74

@Erigara Erigara

@mversic mversic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dima74 @mversic @Erigara