Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move permission migration into executor #4742

Merged
merged 1 commit into from
Jun 25, 2024
Merged

refactor: move permission migration into executor #4742

merged 1 commit into from
Jun 25, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Jun 19, 2024

Description

Linked issue

Closes #{issue_number}

Benefits

we no longer depend on the ExecutorDataModel::permissions being correct.
It's just for users to query it the same way as ExecutorDataModel::custom_instruction is

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@mversic mversic force-pushed the permission_id branch 2 times, most recently from 1e3a5a9 to 6a209aa Compare June 19, 2024 11:01
@mversic
Copy link
Contributor Author

mversic commented Jun 19, 2024

I can't proceed with this PR atm due to #4743

Erigara
Erigara reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks positive

@mversic mversic mentioned this pull request Jun 25, 2024
Merged
5 tasks
@mversic mversic force-pushed the permission_id branch 3 times, most recently from d6afce0 to 5df8b1c Compare June 25, 2024 10:22
@mversic mversic requested a review from Erigara June 25, 2024 10:23
dima74
dima74 previously approved these changes Jun 25, 2024
View reviewed changes
@dima74
Copy link
Contributor

dima74 commented Jun 25, 2024

Looks like executor_upgrade_should_run_migration and migration_should_cause_upgrade_event tests are failing

@mversic
Copy link
Contributor Author

mversic commented Jun 25, 2024

Looks like executor_upgrade_should_run_migration and migration_should_cause_upgrade_event tests are failing

dang. I'll fix

@mversic mversic merged commit 581cc17 into hyperledger-iroha:main Jun 25, 2024
10 of 11 checks passed
@mversic mversic deleted the permission_id branch June 25, 2024 13:57
hollermay pushed a commit to hollermay/iroha that referenced this pull request Jun 28, 2024
@mversic @hollermay
refactor: move permission migration into executor (hyperledger-iroha#…
c86114f 
…4742)

Signed-off-by: Marin Veršić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dima74 dima74 dima74 approved these changes

@Erigara Erigara Erigara approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

Assignees

@dima74 dima74

@Erigara Erigara

@mversic mversic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mversic @dima74 @Erigara